Conversation
changelog: Internal, Source code, Updating dependencies
| builder | ||
| faraday | ||
| nokogiri (>= 1.10.2) | ||
| ostruct |
There was a problem hiding this comment.
so this wasn't a new add overall for the ostruct gem, we already had it, so I'm wondering if the warning was already taken care of? Or this won't affect it?
There was a problem hiding this comment.
maybe? but i bet we need it for the dashboard app, so it's a worthwhile change
There was a problem hiding this comment.
hm ok well we added as an explicit dependecy in https://github.com/18F/identity-idp/pull/11605/files#diff-89cade48462044ee1b672dc5f4c3ec250fbd29effcd8932096a23c1283c6731fR472, but hopefully this helps squash the warning!
There was a problem hiding this comment.
Is it due to ostruct previously only being a dependency of test/dev dependencies?
There was a problem hiding this comment.
oh maybe that's it!
3 participants
Corresponding PR: 18F/saml_idp#133
Goal: fix the ostruct warning