Skip to content

Reduce object allocations in identity verification #11841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 2 commits into from
Feb 5, 2025
Merged

Reduce object allocations in identity verification #11841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fc01e6
Do not try to parse URI if file is not ascii
Feb 5, 2025
454cc73
Reduce object allocations in identity verification
Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 31 additions & 29 deletions app/policies/idv/flow_policy.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,36 @@ class FlowPolicy
attr_reader :idv_session, :user

FINAL = :final
STEPS =
{
root: Idv::StepInfo.new(
key: :root,
controller: AccountsController,
next_steps: [:welcome, :request_letter],
preconditions: ->(idv_session:, user:) { true },
undo_step: ->(idv_session:, user:) { true },
),
welcome: Idv::WelcomeController.step_info,
agreement: Idv::AgreementController.step_info,
how_to_verify: Idv::HowToVerifyController.step_info,
hybrid_handoff: Idv::HybridHandoffController.step_info,
link_sent: Idv::LinkSentController.step_info,
document_capture: Idv::DocumentCaptureController.step_info,
socure_document_capture: Idv::Socure::DocumentCaptureController.step_info,
socure_errors: Idv::Socure::ErrorsController.step_info,
ipp_address: Idv::InPerson::AddressController.step_info,
ssn: Idv::SsnController.step_info,
ipp_ssn: Idv::InPerson::SsnController.step_info,
verify_info: Idv::VerifyInfoController.step_info,
ipp_verify_info: Idv::InPerson::VerifyInfoController.step_info,
address: Idv::AddressController.step_info,
phone: Idv::PhoneController.step_info,
phone_errors: Idv::PhoneErrorsController.step_info,
otp_verification: Idv::OtpVerificationController.step_info,
request_letter: Idv::ByMail::RequestLetterController.step_info,
enter_password: Idv::EnterPasswordController.step_info,
personal_key: Idv::PersonalKeyController.step_info,
}.freeze

def initialize(idv_session:, user:)
@idv_session = idv_session
Expand Down Expand Up @@ -44,35 +74,7 @@ def latest_step(current_step: :root)
end

def steps
{
root: Idv::StepInfo.new(
key: :root,
controller: AccountsController,
next_steps: [:welcome, :request_letter],
preconditions: ->(idv_session:, user:) { true },
undo_step: ->(idv_session:, user:) { true },
),
welcome: Idv::WelcomeController.step_info,
agreement: Idv::AgreementController.step_info,
how_to_verify: Idv::HowToVerifyController.step_info,
hybrid_handoff: Idv::HybridHandoffController.step_info,
link_sent: Idv::LinkSentController.step_info,
document_capture: Idv::DocumentCaptureController.step_info,
socure_document_capture: Idv::Socure::DocumentCaptureController.step_info,
socure_errors: Idv::Socure::ErrorsController.step_info,
ipp_address: Idv::InPerson::AddressController.step_info,
ssn: Idv::SsnController.step_info,
ipp_ssn: Idv::InPerson::SsnController.step_info,
verify_info: Idv::VerifyInfoController.step_info,
ipp_verify_info: Idv::InPerson::VerifyInfoController.step_info,
address: Idv::AddressController.step_info,
phone: Idv::PhoneController.step_info,
phone_errors: Idv::PhoneErrorsController.step_info,
otp_verification: Idv::OtpVerificationController.step_info,
request_letter: Idv::ByMail::RequestLetterController.step_info,
enter_password: Idv::EnterPasswordController.step_info,
personal_key: Idv::PersonalKeyController.step_info,
}
STEPS
end

def step_allowed?(key:)
Expand Down
1 change: 1 addition & 0 deletions app/services/doc_auth/mock/result_response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ def selfie_passed?
end

def parse_uri
return nil if !uploaded_file || !uploaded_file.ascii_only?
uri = URI.parse(uploaded_file.chomp)
if uri.scheme == 'data'
{}
Expand Down