Reduce object allocations in identity verification#11841
Merged
mitchellhenke merged 2 commits intomainfrom Feb 5, 2025
Merged
Conversation
added 2 commits
February 5, 2025 09:20
changelog: Internal, Performance, Reduce object allocations in identity verification
mitchellhenke
deleted the
mitchellhenke/doc-auth-memory-usage-reduction
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
During load testing, these two spaces currently generate a lot of object allocations, particularly the
STEPSelement. It seemed safe to move this into a constant in that looks like it shouldn't change, but I am less familiar with this area of things. In an IdV-only load-test, the allocations saved here might be up to as much of 33% of the memory allocated.