Avoid showing label for unknown event type#11834
Merged
Conversation
changelog: Bug Fixes, Account History, Avoid showing label for unknown event type
zachmargolis
approved these changes
Feb 3, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Related to LG-11867
🛠 Summary of changes
Updates logic of
EventDecorator#event_typeto avoid trying to return a human-readable label for an event type that is not known to the application.This isn't a typical behavior, but the included inline code comment explains the circumstances where it can occur:
As an aside, tracking existing references to
EventDecorator#event_typecan be tricky since the name is the same asEvent#event_type, where only the decorator returns a human-readable label. This label is used on the History and Devices pages. In the future, it could be worth renaming this method to more clearly differentiate (e.g.readable_event_type, orevent_type_label)📜 Testing Plan
Repeat Testing Planf rom #11823 and then switch to this branch. The History page should not show any text for the events associated with adding or removing Face or Touch Unlock. Previously, this would show all of the
event_types.*labels as a stringified hash.👀 Screenshots