Skip to content

LG-11867: Create separate user events for platform authenticators#11823

Merged
aduth merged 1 commit intomainfrom
aduth-lg-11867-webauthn-platform-event
Feb 4, 2025
Merged

LG-11867: Create separate user events for platform authenticators#11823
aduth merged 1 commit intomainfrom
aduth-lg-11867-webauthn-platform-event

Conversation

@aduth
Copy link
Copy Markdown
Contributor

@aduth aduth commented Jan 30, 2025

🎫 Ticket

LG-11867

🛠 Summary of changes

Adds new user event types for Face or Touch Unlock platform authenticators.

The implementation of Face or Touch Unlock built upon support for WebAuthn-based security keys. In the implementation of Face or Touch Unlock, the user experience was segmented based on whether or not the authenticator is a platform authenticator. However, prior to these changes, that did not extend to the user events created for adding an removing the authentication method. As a result, adding or removing Face or Touch Unlock would be reflected on a user's Activity page as "Hardware security key added" and "Hardware security key removed". The intent of these changes is to add new event types so that a more appropriate / familiar "Face or touch unlock added" and "Face or touch unlock removed" label can be shown instead.

📜 Testing Plan

  1. Go to http://localhost:3000
  2. Sign in
  3. From your account dashboard, add and/or remove a Security Key and/or a Face or Touch Unlock credential
  4. After changing your MFA methods, visit the "History" page on the account dashboard
  5. Verify that the label shown under "Activity" matches the expectation of the action you performed:
    • Adding security key = "Hardware security key added"
    • Removing security key = "Hardware security key removed"
    • Adding face or touch unlock = "Face or touch unlock added"
    • Removing face or touch unlock = "Face or touch unlock removed"

👀 Screenshots

Language Screenshot
English history screen
Spanish history screen
French history screen
Chinese history screen

@aduth aduth requested a review from a team January 30, 2025 15:55
@aduth aduth changed the title LG-11867: Create separate user event for platform authenticators LG-11867: Create separate user events for platform authenticators Jan 30, 2025
Copy link
Copy Markdown
Contributor

@kevinsmaster5 kevinsmaster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and local testing works.
Do PRs still need screenshots of the translations for LQA?

@aduth
Copy link
Copy Markdown
Contributor Author

aduth commented Jan 31, 2025

Do PRs still need screenshots of the translations for LQA?

I should have clarified in a comment, but: The strings in the current branch are meant to be temporary. There's a follow-up ticket LG-11867 which will implement the final translations, and we'll want to go through the LQA process for that ticket.

Related Slack thread: https://gsa-tts.slack.com/archives/C05R6BLVAQG/p1738249868960499

@aduth
Copy link
Copy Markdown
Contributor Author

aduth commented Jan 31, 2025

But I'll update the original pull request comment with screenshots showing each language as it is, since that'd be helpful to share regardless of LQA. Good call-out 👍

Edit: Updated screenshots in original comment.

changelog: User-Facing Improvements, Account History, Improve history label when adding or removing Face or Touch Unlock
@aduth aduth force-pushed the aduth-lg-11867-webauthn-platform-event branch from db24f24 to 4490b86 Compare February 4, 2025 19:37
@aduth
Copy link
Copy Markdown
Contributor Author

aduth commented Feb 4, 2025

Pushed rebase reflecting latest main, after merge of changes in #11833 which were deployed in RC 449.

@aduth aduth merged commit 8f0f01a into main Feb 4, 2025
@aduth aduth deleted the aduth-lg-11867-webauthn-platform-event branch February 4, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants