Skip to content

SAML Authn defaults to LOA1 if not specified #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pkarman merged 1 commit into from
Mar 7, 2017
Merged

SAML Authn defaults to LOA1 if not specified #1181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/controllers/concerns/saml_idp_auth_concern.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@ def add_sp_metadata_to_session
end

def requested_authn_context
@requested_authn_context ||= saml_request.requested_authn_context
@requested_authn_context ||= saml_request.requested_authn_context || default_authn_context
end

def default_authn_context
Saml::Idp::Constants::LOA1_AUTHN_CONTEXT_CLASSREF
end

def link_identity_from_session_data
Expand Down
16 changes: 3 additions & 13 deletions spec/controllers/saml_idp_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,24 +210,14 @@
end

context 'authn_context is missing' do
it 'renders nothing with a 401 error' do
it 'defaults to LOA1' do
stub_analytics
allow(@analytics).to receive(:track_event)

saml_get_auth(missing_authn_context_saml_settings)

expect(response.status).to eq(401)
expect(response.body).to be_empty

analytics_hash = {
authn_context: nil,
errors: ['Unauthorized authentication context'],
service_provider: 'http://localhost:3000',
valid: false,
}

expect(@analytics).to have_received(:track_event).
with(Analytics::SAML_AUTH, analytics_hash)
expect(response.status).to eq(302)
expect(@analytics).to_not have_received(:track_event)
Copy link
Copy Markdown
Contributor

@monfresh monfresh Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why expect no analytics? Shouldn't it capture the Analytics::SAML_AUTH event with an LOA1 attribute?

Copy link
Copy Markdown
Contributor Author

@pkarman pkarman Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monfresh you are probably right. I will revisit.

Copy link
Copy Markdown
Contributor Author

@pkarman pkarman Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #1184

end
end

Expand Down