SAML Authn defaults to LOA1 if not specified#1181
Merged
Conversation
**Why**: There is no LOA0 and some SPs are using off-the-shelf integrations that do not allow for customization.
|
Thank you!! |
amoose
pushed a commit
that referenced
this pull request
Mar 7, 2017
**Why**: There is no LOA0 and some SPs are using off-the-shelf integrations that do not allow for customization.
monfresh
reviewed
Mar 7, 2017
| expect(@analytics).to have_received(:track_event). | ||
| with(Analytics::SAML_AUTH, analytics_hash) | ||
| expect(response.status).to eq(302) | ||
| expect(@analytics).to_not have_received(:track_event) |
Contributor
There was a problem hiding this comment.
Why expect no analytics? Shouldn't it capture the Analytics::SAML_AUTH event with an LOA1 attribute?
Contributor
Author
There was a problem hiding this comment.
@monfresh you are probably right. I will revisit.
amoose
pushed a commit
that referenced
this pull request
Mar 8, 2017
**Why**: There is no LOA0 and some SPs are using off-the-shelf integrations that do not allow for customization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: There is no LOA0 and some SPs are using
off-the-shelf integrations that do not allow for customization.