Skip to content

Avoid empty hash default values in analytics methods #11800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Jan 27, 2025
Merged

Avoid empty hash default values in analytics methods #11800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/services/analytics_events.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2077,7 +2077,7 @@ def idv_doc_auth_submitted_pii_validation(
front_image_fingerprint: nil,
back_image_fingerprint: nil,
selfie_image_fingerprint: nil,
classification_info: {},
classification_info: nil,
**extra
)
track_event(
Expand Down Expand Up @@ -6282,7 +6282,7 @@ def password_reset_email(
errors:,
confirmed:,
active_profile:,
error_details: {},
error_details: nil,
**extra
)
track_event(
Expand Down Expand Up @@ -6312,7 +6312,7 @@ def password_reset_password(
profile_deactivated:,
pending_profile_invalidated:,
pending_profile_pending_reasons:,
error_details: {},
error_details: nil,
**extra
)
track_event(
Expand Down
7 changes: 0 additions & 7 deletions spec/controllers/users/reset_passwords_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,6 @@
expect(@analytics).to have_logged_event(
'Password Reset: Password Submitted',
success: true,
error_details: {},
user_id: user.uuid,
profile_deactivated: false,
pending_profile_invalidated: false,
Expand Down Expand Up @@ -391,7 +390,6 @@
expect(@analytics).to have_logged_event(
'Password Reset: Password Submitted',
success: true,
error_details: {},
user_id: user.uuid,
profile_deactivated: true,
pending_profile_invalidated: false,
Expand Down Expand Up @@ -435,7 +433,6 @@
expect(@analytics).to have_logged_event(
'Password Reset: Password Submitted',
success: true,
error_details: {},
user_id: user.uuid,
profile_deactivated: false,
pending_profile_invalidated: false,
Expand Down Expand Up @@ -465,7 +462,6 @@
expect(@analytics).to have_logged_event(
'Password Reset: Email Submitted',
success: true,
error_details: {},
user_id: 'nonexistent-uuid',
confirmed: false,
active_profile: false,
Expand All @@ -491,7 +487,6 @@
expect(@analytics).to have_logged_event(
'Password Reset: Email Submitted',
success: true,
error_details: {},
user_id: user.uuid,
confirmed: true,
active_profile: false,
Expand Down Expand Up @@ -521,7 +516,6 @@
expect(@analytics).to have_logged_event(
'Password Reset: Email Submitted',
success: true,
error_details: {},
user_id: user.uuid,
confirmed: false,
active_profile: false,
Expand All @@ -545,7 +539,6 @@
expect(@analytics).to have_logged_event(
'Password Reset: Email Submitted',
success: true,
error_details: {},
user_id: user.uuid,
confirmed: true,
active_profile: true,
Expand Down