Avoid empty hash default values in analytics methods#11800
Merged
Conversation
mitchellhenke
approved these changes
Jan 24, 2025
changelog: Internal, Analytics, Avoid logging empty hash default values
aduth
force-pushed
the
aduth-nil-default-analytics-events
branch
from
6f12e33 to
df9f391
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates
AnalyticsEventsmethod signatures to avoid assigning a default empty hash value{}, preferringnilinstead to ensure values are omitted from logs.As with #11799, this serves to reduce the size (and cost) of our logging payloads by removing values which aren't relevant for querying. It is not possible to query for an empty hash value in CloudWatch Insights.
This is also an iterative step in the migration away from
errorstoerror_detailswhich will involve makingerror_detailsa guaranteed return value fromFormResponse#to_h.📜 Testing Plan
Verify build passes.