Skip to content

LG-15261 | Trivial tweaks to AAMVA maintenance window file #11725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n1zyy merged 1 commit into from
Jan 8, 2025
Merged

LG-15261 | Trivial tweaks to AAMVA maintenance window file #11725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions app/services/idv/aamva_state_maintenance_window.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ class AamvaStateMaintenanceWindow
],
'MT' => [
# Third Saturday of odd numbered months from 12:00 am to 6:00 am ET
# MW FIXME: I need to test if this is valid, or if the month has to be 1,3,5,7,9,11
{ cron: '0 2 * /2 Sat#3', duration_minutes: 6 * 60 },
],
'NC' => [
Expand All @@ -125,7 +124,6 @@ class AamvaStateMaintenanceWindow
],
'NV' => [
# Tuesdays to Sundays: 2:00 am. to 3:15 am. ET
# MW FIXME: This wraps around, does Tue-Sun get parsed correctly?
Copy link
Copy Markdown
Contributor Author

@n1zyy n1zyy Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, I had tested both of these, but neglected to remove the comments.

{ cron: '0 2 * * Tue-Sun', duration_minutes: 1.25 * 60 },
],
'NY' => [
Expand Down Expand Up @@ -155,8 +153,7 @@ class AamvaStateMaintenanceWindow
],
'TN' => [
# Last Sunday of every month from 11:00 pm Sunday to 2:00 am. Monday ET
{ cron: '0 23 * * Sun#4', duration: 3 * 60 },
{ cron: '0 23 * * Sun#5', duration: 3 * 60 },
{ cron: '0 23 * * Sun#last', duration: 3 * 60 },
],
'TX' => [
# Saturday 9:00 pm. to Sunday 7:00 am. ET.
Expand Down