LG-15261 | Trivial tweaks to AAMVA maintenance window file#11725
Merged
Conversation
[skip changelog]
n1zyy
commented
Jan 8, 2025
| ], | ||
| 'NV' => [ | ||
| # Tuesdays to Sundays: 2:00 am. to 3:15 am. ET | ||
| # MW FIXME: This wraps around, does Tue-Sun get parsed correctly? |
Contributor
Author
There was a problem hiding this comment.
For the record, I had tested both of these, but neglected to remove the comments.
zachmargolis
approved these changes
Jan 8, 2025
matthinz
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip changelog]
🎫 Ticket
Link to the relevant ticket:
LG-15261
🛠 Summary of changes
My previous PR for this was #11705 and explained it well. This cleans up a couple trivial things:
Sun#lastis valid with fugit so I can correctly define the window