Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

18F / identity-idp Public

Notifications You must be signed in to change notification settings
Fork 166
Star 575

Code
Issues 2
Pull requests 26
Projects
Wiki
Security and quality
Insights

Additional navigation options

Code
Issues
Pull requests
Projects
Wiki
Security and quality
Insights

LG-15248: Account Management no change available#11701

Merged

jmdembe merged 54 commits intomain18F/identity-idp:mainfrom

jd-LG-15248-hide-change-button18F/identity-idp:jd-LG-15248-hide-change-buttonCopy head branch name to clipboard

Jan 28, 2025

Conversation Commits54 (54)Checks Files changed

Merged

LG-15248: Account Management no change available#11701
jmdembe merged 54 commits intomainfrom
jd-LG-15248-hide-change-button

Commits

Commits on Jan 28, 2025

add requested attribute to accounts_show_presenter
jmdembe
committed
add logic for decorated_sp_session
jmdembe
committed
check for requested_attributes and ial2_requested
jmdembe
committed
add tests for requested attribes and ial2 requested
jmdembe
committed
changelog: User-Facing Improvements, account management, no change available if partner shares all emails
jmdembe
committed
add logic to show/hide change button
jmdembe
committed
clean up controller and presenter
jmdembe
committed
clean up requested_attributes in the rest of controllers and specs
jmdembe
committed
change logic for all emails requested as well as `nil` to `false` in specs
jmdembe
committed
remove `ial2_requested`
jmdembe
committed
lintfix
jmdembe
committed
fix logic to show desired behavior when is false
jmdembe
committed
remove debugger
jmdembe
committed
fix logic
jmdembe
committed
add supporting test for view
jmdembe
committed
match `all_emails_requested` to be a boolean value
jmdembe
committed
add logic for if the partner does not have `email` as a consented attribute
jmdembe
committed
logic change to `all_emails_requested?`
jmdembe
committed
refine check for no email (WIP), refine method name
jmdembe
committed
fix all broken tests
jmdembe
committed
change service provider -> partner
jmdembe
committed
more logic correction
jmdembe
committed
rename and fix logic
jmdembe
committed
Update app/controllers/accounts/connected_accounts_controller.rb

jmdembe
and
aduth
committed
change `all_emails requested` -> `change_email_available?`
jmdembe
committed
remove `change_email_available`
jmdembe
committed
move logic around
jmdembe
committed
logic in presenter and view
jmdembe
committed
change to `change_option_available`, fix test
jmdembe
committed
edit test block
jmdembe
committed
change name to be more intuitive
jmdembe
committed
add tests to view
jmdembe
committed
fix account show presenter tests
jmdembe
committed
method name cleanup
jmdembe
committed
more test fixes
jmdembe
committed
more changes
jmdembe
committed
fix eager loading problem

jmdembe
and
aduth
committed
lintfix
jmdembe
committed
add test
jmdembe
committed
test 1 for connected apps
jmdembe
committed
check against `identities` and pass value
jmdembe
committed
place logic in model, remove logic from presenter and controller, add check to presenter
jmdembe
committed
no longer doing logic in controller, so return connected apps to previous state
jmdembe
committed
remove `requested_attributes`
jmdembe
committed
fix logic in model and view
jmdembe
committed
method name change
jmdembe
committed
remove unneeded keyword
jmdembe
committed
fix tests
jmdembe
committed
Repurpose ServiceProviderIdentity#hide_change_email? as verified_single_email_attribute?

aduth
authored and
jmdembe
committed
Revert changes to ApplicationController, AccountShowPresenter spec

aduth
authored and
jmdembe
committed
Handle nil verified_attributes

aduth
authored and
jmdembe
committed
Update tests for connected accounts view

aduth
authored and
jmdembe
committed
Exempt eager loading error validation for connected accounts

aduth
authored and
jmdembe
committed
Update stubbed identity in connected accounts feature spec to include email

aduth
authored and
jmdembe
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.