LG-15248: Account Management no change available

[jmdembe]

🎫 Ticket

Link to the relevant ticket:
LG-15248

🛠 Summary of changes

On the connected accounts screen, the "change" option is not shown when

• all_emails is a requested_attribute; or
• email does not exist on requested attribute

📜 Testing Plan

Before testing: Clone, setup, and start the identity-oidc-sinatra app and set feature_select_email_to_share_enabled to true

Default behavior:

• In the identity-oidc-sinatra app, leave all options checked in requested_attributes
• Once on the identity-idp app, follow all steps to create a new account
• Once your email is confirmed, follow all steps to set up 2FA
• After setup, you will be on the /account page. Click Your connected accounts on the left side of the page
• Once on the connected accounts page, you will see "Example Sinatra App" as a connected account. Observe that the "change" link appears

Simulating missing email or present all_emails attribute

• In the identity-oidc-sinatra app, either uncheck email or uncheck email and check all_emails
• Once on the identity-idp app, follow all steps to create a new account
• Once your email is confirmed, follow all steps to set up 2FA
• After setup, you will be on the /account page. Click Your connected accounts on the left side of the page
• Once on the connected accounts page, you will see "Example Sinatra App" as a connected account. Observe that the "change" does not appear

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

When `email` is requested attribute

Screen.Recording.2025-01-08.at.1.46.46.PM.mov

When `all_emails` is a requested attribute

all.emails.no.change.link.mov

When `email` are not a requested attribute

https://github.com/user-attachments/assets/0f3b9cfe-ed76-48ca-8bc9-23e650bec4ea

[aduth]

To me, part of the benefit of having a presenter like this is to help keep controllers lean by moving the logic into the presenter class, but in this case we're using the presenter as a pass-through and having the logic in the controller.

Instead, I might have expected that we could pass a value which is more readily available (decorated_sp_session.requested_attributes or decorated_sp_session) and do the logic in the presenter.

[aduth]

This seems to be looking at the requested attribute for the current request, not for each connected application. We want the link to be available for any connection where the requested attribute includes email.

[aduth]

We also don't want to show the "selected" email if the connected application didn't request email.

From the ticket:

"No email selected" / selected email [...] are not shown

[jmdembe]

Making sure I understand the changes to be made--so it should look like this:

[aduth]

I think we'd want to fix up the stray "with:" there. I think this changed in the pull request which originally added the feature, so we might be able to get some strings from the previous implementation to use.

It might also be worth double-checking with the UX folks, but other than that, I think it's what I'd expect.

[jmdembe]

That makes sense.

[aduth]

cc @mdiarra3 I think we should align between this pull request and #11717 and have a single method, since this is being used for the same purpose.

Since this lives in the model, we should also avoid any UI-specific naming, so something like verified_single_email_attribute? similar to #11717 would be my vote.

[aduth]

Approving with caveat that a handful of the recent commits are my own, so please review whether those make sense to you before merging.

[aduth]

Can you also make sure to rebase this branch before merging