Yamada/lg 15068 content updates on ready to verify view and email for id ipp by gina-yamada · Pull Request #11687 · 18F/identity-idp

gina-yamada · 2024-12-27T16:20:38Z

🎫 Ticket

LG-15068: Content/ translation updates to Ready to Verify Email and View, see Figma

🛠 Summary of changes

Step 1 Create an IPP enrollment
Step 2 Inspect Ready to Verify email in English, Spanish, French, and Chinese
Step 3 Inspect Ready to Verify view in English, Spanish, French, and Chinese
Step 4 Create an EIPP enrollment
Step 5 Inspect Ready to Verify email in English, Spanish, French, and Chinese
Step 6 Inspect Ready to Verify view in English, Spanish, French, and Chinese

👀 Screenshots

IPP Ready To Verify Email

Before	After

IPP Ready to Verify View

Before	After

EIPP Ready To Verify Email

Before	After

EIPP Ready to Verify View

Before	After

…translation changes to Ready to Verify View and Email

WilliamBirdsall

LGTM :)

kellular

Cross-referenced with the Figma and the translations spreadsheet—updates LGTM

…68-ContentUpdatesOnReadyToVerifyViewAndEmailForID-IPP

eileen-nava · 2025-01-02T20:14:55Z

app/views/user_mailer/shared/_in_person_ready_to_verify.html.erb

 <% end %>

-<%# What to expect at the Post Office %>
+<%# What to do at the Post Office %>


I started to look at this PR, but paused while Gina confirms a punctuation detail.

@gina-yamada I did another review today. Everything looks good. Approved!

gina-yamada · 2025-01-02T21:22:03Z

Notes for myselt:

main branch

language	account.index.verification.in_person_instructions_html translation	in_person_proofing.body.barcode.deadline translation
English	You must visit any participating Post Office by %{deadline} to verify your identity.	You must visit any participating Post Office by %{deadline}.
Spanish	Para terminar de verificar su identidad, debe acudir a una oficina de correos participante antes del %{deadline}.	Debe acudir a cualquier oficina de correos participante antes del %{deadline}
French	Vous devez vous rendre à un bureau de poste participant d’ici le %{deadline} pour terminer la procédure de vérification de votre identité.	Vous devez vous rendre dans un bureau de poste participant avant le %{deadline}
Chinese	你必须在 %{deadline} 之前去邮局完成验证你的身份。	你必须在 %{deadline}之前去任何参与邮局。

yamada/LG-15068-ContentUpdatesOnReadyToVerifyViewAndEmailForID-IPP branch

language	account.index.verification.in_person_instructions_html translation	in_person_proofing.body.barcode.deadline translation
English	You must visit any participating Post Office by %{deadline} to verify your identity. (restored)	You must visit any participating Post Office by %{deadline}.
Spanish	Para terminar de verificar su identidad, debe acudir a una oficina de correos participante antes del %{deadline}.	Debe acudir a cualquier oficina de correos participante antes del %{deadline}
French	Vous devez vous rendre à un bureau de poste participant d’ici le %{deadline} pour terminer la procédure de vérification de votre identité. (restored)	Vous devez vous rendre dans un bureau de poste participant avant le %{deadline}
Chinese	你必须在 %{deadline} 之前去邮局完成验证你的身份。 (restored)	你必须在 %{deadline}之前去任何参与邮局。

…68-ContentUpdatesOnReadyToVerifyViewAndEmailForID-IPP

gina-yamada · 2025-01-08T15:36:00Z

@WilliamBirdsall @eileen-nava

I mistakenly changed the translation for account.index.verification.in_person_instructions_html in English, French, and Chinese. This updated text on /account. I changed it back (see commit history) since you last reviewed this so I am asking for another review.

Thanks

To re-test after my changes....

Coming in through oidc-sinatra. Create an account. Run through the In-person proofing flow.
Inspect the Ready to Verify email and view for the correct translation in the banner. It should read... "You must visit any participating Post Office by February 6, 2025.". (It should not be "You must visit any participating Post Office by February 6, 2025 to verify your identity."). Inspect all translation updates/changes mentioned above in the original testing plan.
Repeat step 2 for English, Spanish, French, and Chinese.
Change the url to http://localhost:3000/account. Inspect the banner inside the Identity verification section. It should read... You must visit any participating Post Office by February 6, 2025 to verify your identity. (it includes 'to verify your identity`.) (I accidentally changed this translation. It should now be fixed.)
Repeat step 4 for English, Spanish, French, and Chinese.

Ready to Verify Email & View Screenshots

Screenshot of entire view tested 01/08

Account View

DEV to show what it should be....

My Branch is now the same as dev

gina-yamada · 2025-01-08T15:39:42Z

@kellular More of just an fyi, see comment above. I don't think you need to review- no views/translation on Ready to Verify have changed. I did mistakenly update a text string that was very similar that made a change on /account. I reverted that change.

eileen-nava

Approved. 👍🏻

eileen-nava · 2025-01-09T17:57:54Z

app/views/user_mailer/shared/_in_person_ready_to_verify.html.erb

 <% end %>

-<%# What to expect at the Post Office %>
+<%# What to do at the Post Office %>


@gina-yamada I did another review today. Everything looks good. Approved!

…68-ContentUpdatesOnReadyToVerifyViewAndEmailForID-IPP

gina-yamada added 4 commits December 27, 2024 08:46

Content updates to Ready to Verify view/email

b515cae

changelog: User-Facing Improvements, In-person proofing, Content and …

ddbf543

…translation changes to Ready to Verify View and Email

Fix linter errors and add missing tag

cecf7c4

Content updates for Ready to Verify Email/View

10947c9

gina-yamada marked this pull request as ready for review December 27, 2024 19:05

gina-yamada requested a review from shanechesnutt-ft December 30, 2024 15:12

WilliamBirdsall approved these changes Dec 30, 2024

View reviewed changes

kellular approved these changes Jan 2, 2025

View reviewed changes

gina-yamada removed the request for review from shanechesnutt-ft January 2, 2025 17:16

Merge branch 'main' of github.com:18F/identity-idp into yamada/LG-150…

e562f5b

…68-ContentUpdatesOnReadyToVerifyViewAndEmailForID-IPP

eileen-nava reviewed Jan 2, 2025

View reviewed changes

gina-yamada added 3 commits January 3, 2025 09:17

Restore translations

325b02f

Add punctuation to translations

bbfb306

Merge branch 'main' of github.com:18F/identity-idp into yamada/LG-150…

dccd7fd

…68-ContentUpdatesOnReadyToVerifyViewAndEmailForID-IPP

gina-yamada requested review from WilliamBirdsall and eileen-nava January 8, 2025 15:36

eileen-nava approved these changes Jan 9, 2025

View reviewed changes

Merge branch 'main' of github.com:18F/identity-idp into yamada/LG-150…

7dd8225

…68-ContentUpdatesOnReadyToVerifyViewAndEmailForID-IPP

gina-yamada merged commit d574623 into main Jan 10, 2025

gina-yamada deleted the yamada/LG-15068-ContentUpdatesOnReadyToVerifyViewAndEmailForID-IPP branch January 10, 2025 15:28

jmhooper mentioned this pull request Jan 14, 2025

Deploy RC 443 to Production #11748

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Yamada/lg 15068 content updates on ready to verify view and email for id ipp#11687

Yamada/lg 15068 content updates on ready to verify view and email for id ipp#11687
gina-yamada merged 9 commits intomainfrom
yamada/LG-15068-ContentUpdatesOnReadyToVerifyViewAndEmailForID-IPP

gina-yamada commented Dec 27, 2024 •

edited by eileen-nava

Loading

Uh oh!

WilliamBirdsall left a comment

Uh oh!

kellular left a comment

Uh oh!

eileen-nava Jan 2, 2025 •

edited

Loading

Uh oh!

eileen-nava Jan 9, 2025

Uh oh!

gina-yamada commented Jan 2, 2025 •

edited

Loading

Uh oh!

gina-yamada commented Jan 8, 2025 •

edited

Loading

Uh oh!

gina-yamada commented Jan 8, 2025

Uh oh!

eileen-nava left a comment

Uh oh!

eileen-nava Jan 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gina-yamada commented Dec 27, 2024 • edited by eileen-nava Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎫 Ticket

🛠 Summary of changes

👀 Screenshots

Uh oh!

WilliamBirdsall left a comment

Choose a reason for hiding this comment

Uh oh!

kellular left a comment

Choose a reason for hiding this comment

Uh oh!

eileen-nava Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eileen-nava Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

gina-yamada commented Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gina-yamada commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gina-yamada commented Jan 8, 2025

Uh oh!

eileen-nava left a comment

Choose a reason for hiding this comment

Uh oh!

eileen-nava Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gina-yamada commented Dec 27, 2024 •

edited by eileen-nava

Loading

eileen-nava Jan 2, 2025 •

edited

Loading

gina-yamada commented Jan 2, 2025 •

edited

Loading

gina-yamada commented Jan 8, 2025 •

edited

Loading