Skip to content

Update saml_idp gem to add support for AES-GCM encryption algorithms #11593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 1 commit into from
Dec 4, 2024
Merged

Update saml_idp gem to add support for AES-GCM encryption algorithms #11593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ gem 'rqrcode'
gem 'ruby-progressbar'
gem 'ruby-saml'
gem 'safe_target_blank', '>= 1.0.2'
gem 'saml_idp', github: '18F/saml_idp', tag: '0.23.3-18f'
gem 'saml_idp', github: '18F/saml_idp', tag: '0.23.4-18f'
gem 'scrypt'
gem 'simple_form', '>= 5.0.2'
gem 'stringex', require: false
Expand All @@ -85,7 +85,7 @@ gem 'valid_email', '>= 0.1.3', github: 'hallelujah/valid_email', ref: '486b860'
gem 'view_component', '~> 3.0'
gem 'webauthn', '~> 2.5.2'
gem 'xmldsig', '~> 0.6'
gem 'xmlenc', '~> 0.7', '>= 0.7.1'
gem 'xmlenc', '0.8.0'
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we keep the version that allows patch changes? This would allow 0.8.1 automatically I think

Suggested change
gem 'xmlenc', '0.8.0'
gem 'xmlenc', '~> 0.8'

Copy link
Copy Markdown
Contributor Author

@mitchellhenke mitchellhenke Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would, but the gem is very rarely updated and I'm not confident in version updates being safe without some more explicit checks 😅

Copy link
Copy Markdown
Contributor

@aduth aduth Dec 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coincidentally I'd tried that syntax earlier in #11590 (gem 'rubocop', '~> 1.69') hoping for the behavior you described, but it installed the outdated .0 version (1.69.0) instead of the latest version (1.69.1) 🤷

gem 'yard', require: false
gem 'zlib', require: false

Expand Down
8 changes: 4 additions & 4 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ GIT

GIT
remote: https://github.com/18F/saml_idp.git
revision: 752085a6f88cd3ce75ecc7a64afe064a0e4f9e35
tag: 0.23.3-18f
revision: e5d876cf10ce9b39bba0cc523d06c4dda1af5124
tag: 0.23.4-18f
specs:
saml_idp (0.23.3.pre.18f)
saml_idp (0.23.4.pre.18f)
activesupport
builder
faraday
Expand Down Expand Up @@ -869,7 +869,7 @@ DEPENDENCIES
webauthn (~> 2.5.2)
webmock
xmldsig (~> 0.6)
xmlenc (~> 0.7, >= 0.7.1)
xmlenc (= 0.8.0)
yard
zlib
zonebie
Expand Down