Skip to content

Remove unused event parameter from RedirectController #11576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Dec 2, 2024
Merged

Remove unused event parameter from RedirectController #11576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions app/controllers/redirect/redirect_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,8 @@ def partner_params
}.compact
end

def redirect_to_and_log(url, event: nil, tracker_method: analytics.method(:external_redirect))
if event
# Once all events have been moved to tracker methods, we can remove the event: param
analytics.track_event(event, redirect_url: url, **location_params)
else
tracker_method.call(redirect_url: url, **location_params)
end

def redirect_to_and_log(url, tracker_method: analytics.method(:external_redirect))
tracker_method.call(redirect_url: url, **location_params)
redirect_url = UriService.add_params(url, partner_params)
redirect_to(redirect_url, allow_other_host: true)
end
Expand Down