Remove unused event parameter from RedirectController#11576
Merged
Conversation
changelog: Internal, Analytics, Remove unused event parameter from RedirectController
mitchellhenke
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes the unused
eventkeyword argument from theredirect_to_and_logprivate controller method for theRedirectControllerbase controller.This was superseded by the
tracker_methodkeyword argument and slated for eventual removal. Based on current usage, there are no instances ofeventkeyword argument and it can be safely removed.📜 Testing Plan
Verify build passes.
Double-check for existing usage of the
eventkeyword argument.