Skip to content

LG-12269 Improve ID-IPP feature test structure #11506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shanechesnutt-ft merged 1 commit into from
Nov 19, 2024
Merged

LG-12269 Improve ID-IPP feature test structure #11506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions spec/features/idv/steps/in_person/address_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
expect_in_person_step_indicator_current_step(t('step_indicator.flows.idv.verify_info'))
expect(page).to have_current_path(idv_in_person_verify_info_url)
expect(page).to have_text(InPersonHelper::GOOD_ADDRESS1)
expect(page).to have_text(InPersonHelper::GOOD_ADDRESS2)
expect(page).to have_text(InPersonHelper::GOOD_CITY)
expect(page).to have_text(InPersonHelper::GOOD_ZIPCODE)
expect(page).to have_text(Idp::Constants::MOCK_IDV_APPLICANT_STATE)
Expand All @@ -72,7 +71,6 @@
# address page has fields that are pre-populated
expect(page).to have_content(t('in_person_proofing.headings.update_address'))
expect(page).to have_field(t('idv.form.address1'), with: InPersonHelper::GOOD_ADDRESS1)
expect(page).to have_field(t('idv.form.address2'), with: InPersonHelper::GOOD_ADDRESS2)
expect(page).to have_field(t('idv.form.city'), with: InPersonHelper::GOOD_CITY)
expect(page).to have_field(t('idv.form.zipcode'), with: InPersonHelper::GOOD_ZIPCODE)
expect(page).to have_field(
Expand All @@ -82,8 +80,8 @@
end
end

context 'Transliterable Validation' do
before(:each) do
context 'transliterable Validation' do
Copy link
Copy Markdown
Contributor

@eileen-nava eileen-nava Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: While making changes in here, what would you think of changing before(:each) to before? Since before's scope defaults to each, I'm not sure the benefit of writing before(:each) instead of before.

I'm also wondering if it's be worth changing the capitalization for validation, too?

Copy link
Copy Markdown
Contributor Author

@shanechesnutt-ft shanechesnutt-ft Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch I will update those

Comment thread
eileen-nava marked this conversation as resolved.
Outdated
before do
allow(IdentityConfig.store).to receive(:usps_ipp_transliteration_enabled).
and_return(true)
end
Expand Down Expand Up @@ -134,7 +132,7 @@
end
end

context 'Validation' do
Comment thread
gina-yamada marked this conversation as resolved.
Outdated
context 'validation' do
it 'validates zip code input', allow_browser_log: true do
complete_idv_steps_before_address

Expand All @@ -156,7 +154,7 @@
end
end

context 'State selection' do
context 'state selection' do
it 'shows address hint when user selects state that has a specific hint',
allow_browser_log: true do
complete_idv_steps_before_address
Expand Down
274 changes: 129 additions & 145 deletions ...eps/in_person/state_id_controller_spec.rb → ...ures/idv/steps/in_person/state_id_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,7 @@

expect(page).to have_content(t('forms.buttons.continue'))
expect(page).to have_content(
strip_nbsp(
t(
'in_person_proofing.headings.state_id_milestone_2',
),
),
strip_nbsp(t('in_person_proofing.headings.state_id_milestone_2')),
)
end

Expand Down Expand Up @@ -122,157 +118,145 @@
)
end

context 'same address as id',
Comment thread
gina-yamada marked this conversation as resolved.
Outdated
allow_browser_log: true do
context 'same_address_as_id', allow_browser_log: true do
let(:user) { user_with_2fa }

before(:each) do
before do
sign_in_and_2fa_user(user)
begin_in_person_proofing(user)
complete_prepare_step(user)
complete_location_step(user)
end

it 'does not update their previous selection of "Yes,
I live at the address on my state-issued ID"' do
complete_state_id_controller(user, same_address_as_id: true)
# skip address step
complete_ssn_step(user)
# expect to be on verify page
expect(page).to have_content(t('headings.verify'))
expect(page).to have_current_path(idv_in_person_verify_info_path)
# click update state ID button on the verify page
click_link t('idv.buttons.change_state_id_label')
# expect to be on the state ID page
expect(page).to have_content(t('in_person_proofing.headings.update_state_id'))
# change address
fill_in t('in_person_proofing.form.state_id.address1'), with: ''
fill_in t('in_person_proofing.form.state_id.address1'), with: 'test update address'
click_button t('forms.buttons.submit.update')
# expect to be back on verify page
expect(page).to have_content(t('headings.verify'))
expect(page).to have_current_path(idv_in_person_verify_info_path)
expect(page).to have_content(t('headings.verify'))
# expect to see state ID address update on verify twice
expect(page).to have_text('test update address').twice # for state id addr and addr update
# click update state id address
click_link t('idv.buttons.change_state_id_label')
# expect to be on the state ID page
expect(page).to have_content(t('in_person_proofing.headings.update_state_id'))
# expect "Yes, I live at a different address" is checked"
expect(page).to have_checked_field(
t('in_person_proofing.form.state_id.same_address_as_id_yes'),
visible: false,
)
end

it 'does not update their previous selection of "No, I live at a different address"' do
complete_state_id_controller(user, same_address_as_id: false)
# expect to be on address page
expect(page).to have_content(t('in_person_proofing.headings.address'))
# complete address step
complete_address_step(user)
complete_ssn_step(user)
# expect to be back on verify page
expect(page).to have_content(t('headings.verify'))
expect(page).to have_current_path(idv_in_person_verify_info_path)
# click update state ID button on the verify page
click_link t('idv.buttons.change_state_id_label')
# expect to be on the state ID page
expect(page).to have_content(t('in_person_proofing.headings.update_state_id'))
# change address
fill_in t('in_person_proofing.form.state_id.address1'), with: ''
fill_in t('in_person_proofing.form.state_id.address1'), with: 'test update address'
click_button t('forms.buttons.submit.update')
# expect to be back on verify page
expect(page).to have_content(t('headings.verify'))
expect(page).to have_current_path(idv_in_person_verify_info_path)
expect(page).to have_content(t('headings.verify'))
# expect to see state ID address update on verify
expect(page).to have_text('test update address').once # only state id address update
# click update state id address
click_link t('idv.buttons.change_state_id_label')
# expect to be on the state ID page
expect(page).to have_content(t('in_person_proofing.headings.update_state_id'))
expect(page).to have_checked_field(
t('in_person_proofing.form.state_id.same_address_as_id_no'),
visible: false,
)
end

it 'updates their previous selection from "Yes" TO "No, I live at a different address"' do
complete_state_id_controller(user, same_address_as_id: true)
# skip address step
complete_ssn_step(user)
# click update state ID button on the verify page
click_link t('idv.buttons.change_state_id_label')
# expect to be on the state ID page
expect(page).to have_content(t('in_person_proofing.headings.update_state_id'))
# change address
fill_in t('in_person_proofing.form.state_id.address1'), with: ''
fill_in t('in_person_proofing.form.state_id.address1'), with: 'test update address'
# change response to No
choose t('in_person_proofing.form.state_id.same_address_as_id_no')
click_button t('forms.buttons.submit.update')
# expect to be on address page
expect(page).to have_content(t('in_person_proofing.headings.address'))
# complete address step
complete_address_step(user)
# expect to be on verify page
expect(page).to have_content(t('headings.verify'))
expect(page).to have_current_path(idv_in_person_verify_info_path)
# expect to see state ID address update on verify
expect(page).to have_text('test update address').once # only state id address update
# click update state id address
click_link t('idv.buttons.change_state_id_label')
# expect to be on the state ID page
expect(page).to have_content(t('in_person_proofing.headings.update_state_id'))
# check that the "No, I live at a different address" is checked"
expect(page).to have_checked_field(
t('in_person_proofing.form.state_id.same_address_as_id_no'),
visible: false,
)
context 'when the user answers "Yes" for same address as state ID' do
before do
complete_state_id_controller(user, same_address_as_id: true)
complete_ssn_step(user)
click_link t('idv.buttons.change_state_id_label')
end

context 'when the user does not update the same address value' do
it 'does not change their previous selection' do
# expect to be on the state ID page
expect(page).to have_content(t('in_person_proofing.headings.update_state_id'))
# change address
fill_in t('in_person_proofing.form.state_id.address1'), with: ''
fill_in t('in_person_proofing.form.state_id.address1'), with: 'test update address'
click_button t('forms.buttons.submit.update')
# expect to be back on verify page
expect(page).to have_content(t('headings.verify'))
expect(page).to have_current_path(idv_in_person_verify_info_path)
expect(page).to have_content(t('headings.verify'))
# expect to see state ID address update on verify twice
# for state id address and address update
expect(page).to have_text('test update address').twice
# click update state id address
click_link t('idv.buttons.change_state_id_label')
# expect to be on the state ID page
expect(page).to have_content(t('in_person_proofing.headings.update_state_id'))
# expect "Yes, I live at a different address" is checked"
expect(page).to have_checked_field(
t('in_person_proofing.form.state_id.same_address_as_id_yes'),
visible: false,
)
end
end

context 'when the user updates the same address value to "No"' do
it 'updates their selection to "No"' do
expect(page).to have_content(t('in_person_proofing.headings.update_state_id'))
# change address
fill_in t('in_person_proofing.form.state_id.address1'), with: ''
fill_in t('in_person_proofing.form.state_id.address1'), with: 'test update address'
# change response to No
choose t('in_person_proofing.form.state_id.same_address_as_id_no')
click_button t('forms.buttons.submit.update')
# expect to be on address page
expect(page).to have_content(t('in_person_proofing.headings.address'))
# complete address step
complete_address_step(user)
# expect to be on verify page
expect(page).to have_content(t('headings.verify'))
expect(page).to have_current_path(idv_in_person_verify_info_path)
# expect to see state ID address update on verify
expect(page).to have_text('test update address').once # only state id address update
# click update state id address
click_link t('idv.buttons.change_state_id_label')
# expect to be on the state ID page
expect(page).to have_content(t('in_person_proofing.headings.update_state_id'))
# check that the "No, I live at a different address" is checked"
expect(page).to have_checked_field(
t('in_person_proofing.form.state_id.same_address_as_id_no'),
visible: false,
)
end
end
end

it 'updates their previous selection from "No" TO "Yes,
I live at the address on my state-issued ID"' do
complete_state_id_controller(user, same_address_as_id: false)
# expect to be on address page
expect(page).to have_content(t('in_person_proofing.headings.address'))
# complete address step
complete_address_step(user)
complete_ssn_step(user)
# expect to be on verify page
expect(page).to have_content(t('headings.verify'))
expect(page).to have_current_path(idv_in_person_verify_info_path)
# click update state ID button on the verify page
click_link t('idv.buttons.change_state_id_label')
# expect to be on the state ID page
expect(page).to have_content(t('in_person_proofing.headings.update_state_id'))
# change address
fill_in t('in_person_proofing.form.state_id.address1'), with: ''
fill_in t('in_person_proofing.form.state_id.address1'), with: 'test update address'
# change response to Yes
choose t('in_person_proofing.form.state_id.same_address_as_id_yes')
click_button t('forms.buttons.submit.update')
# expect to be back on verify page
expect(page).to have_content(t('headings.verify'))
expect(page).to have_current_path(idv_in_person_verify_info_path)
# expect to see state ID address update on verify twice
expect(page).to have_text('test update address').twice # for state id addr and addr update
# click update state ID button on the verify page
click_link t('idv.buttons.change_state_id_label')
# expect to be on the state ID page
expect(page).to have_content(t('in_person_proofing.headings.update_state_id'))
expect(page).to have_checked_field(
t('in_person_proofing.form.state_id.same_address_as_id_yes'),
visible: false,
)
context 'when the user answers "No" for same address as state ID' do
before do
complete_state_id_controller(user, same_address_as_id: false)
complete_address_step(user)
complete_ssn_step(user)
click_link t('idv.buttons.change_state_id_label')
end

context 'when the user does not update the same address value' do
it 'does not change their previous selection' do
# expect to be on the state ID page
expect(page).to have_content(t('in_person_proofing.headings.update_state_id'))
# change address
fill_in t('in_person_proofing.form.state_id.address1'), with: ''
fill_in t('in_person_proofing.form.state_id.address1'), with: 'test update address'
click_button t('forms.buttons.submit.update')
# expect to be back on verify page
expect(page).to have_content(t('headings.verify'))
expect(page).to have_current_path(idv_in_person_verify_info_path)
expect(page).to have_content(t('headings.verify'))
# expect to see state ID address update on verify
expect(page).to have_text('test update address').once # only state id address update
# click update state id address
click_link t('idv.buttons.change_state_id_label')
# expect to be on the state ID page
expect(page).to have_content(t('in_person_proofing.headings.update_state_id'))
expect(page).to have_checked_field(
t('in_person_proofing.form.state_id.same_address_as_id_no'),
visible: false,
)
end
end

context 'when the user updates the same address value to "Yes"' do
it 'updates their selection to "Yes"' do
# expect to be on the state ID page
expect(page).to have_content(t('in_person_proofing.headings.update_state_id'))
# change address
fill_in t('in_person_proofing.form.state_id.address1'), with: ''
fill_in t('in_person_proofing.form.state_id.address1'), with: 'test update address'
# change response to Yes
choose t('in_person_proofing.form.state_id.same_address_as_id_yes')
click_button t('forms.buttons.submit.update')
# expect to be back on verify page
expect(page).to have_content(t('headings.verify'))
expect(page).to have_current_path(idv_in_person_verify_info_path)
# expect to see state ID address update on verify twice
# for state id address and address update
expect(page).to have_text('test update address').twice
# click update state ID button on the verify page
click_link t('idv.buttons.change_state_id_label')
# expect to be on the state ID page
expect(page).to have_content(t('in_person_proofing.headings.update_state_id'))
expect(page).to have_checked_field(
t('in_person_proofing.form.state_id.same_address_as_id_yes'),
visible: false,
)
end
end
Comment thread
gina-yamada marked this conversation as resolved.
Outdated
end
end
end

context 'Validation' do
context 'validation' do
it 'validates zip code input', allow_browser_log: true do
complete_steps_before_state_id_controller

Expand Down Expand Up @@ -325,8 +309,8 @@
end
end

context 'Transliterable Validation' do
before(:each) do
context 'transliterable validation' do
before do
allow(IdentityConfig.store).to receive(:usps_ipp_transliteration_enabled).
and_return(true)
end
Expand Down Expand Up @@ -394,7 +378,7 @@
end
end

context 'State selection' do
context 'state selection' do
it 'shows address hint when user selects state that has a specific hint',
allow_browser_log: true do
complete_steps_before_state_id_controller
Expand Down
Loading