Skip to content

Internal, Analytics, Fix bug in protocols report #11447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sgtpluck merged 1 commit into from
Nov 4, 2024
Merged

Internal, Analytics, Fix bug in protocols report #11447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/reporting/protocols_report.rb
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@aduth aduth Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any test coverage for this?

Copy link
Copy Markdown
Contributor Author

@Sgtpluck Sgtpluck Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's test coverage, but it's hard to test this stuff e2e since we have to stub out the cloudwatch requests. next time i'm in this code, i'll see if i can set up some spies or something to ensure the queries look as expected

Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ def saml_signature_query
QUERY
end

def fetch_uniq_issuers(query)
def fetch_uniq_issuers(query:)
by_uniq_issuers(
cloudwatch_client.fetch(
query:,
Expand Down