Internal, Analytics, Fix bug in protocols report#11447
Merged
Conversation
Sgtpluck
force-pushed
the
dmm/fix-malformed-query
branch
from
2431bfc to
72fdb61
Compare
Contributor
|
Last weekend the report arrived late and yesterday's has not arrived yet. Is this somehow the cause or something else? |
Contributor
Author
|
this is the cause of it not arriving this week, yes -- when this is deployed i'll trigger the job for this week |
aduth
reviewed
Nov 4, 2024
Contributor
There was a problem hiding this comment.
Is there any test coverage for this?
Contributor
Author
There was a problem hiding this comment.
there's test coverage, but it's hard to test this stuff e2e since we have to stub out the cloudwatch requests. next time i'm in this code, i'll see if i can set up some spies or something to ensure the queries look as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes a bug I introduced when I refactored some of the code. 🙈 I'd run the report before making a method out of the similar queries, but not after.
I did run the report after fixing this, and it appear to work both in the console and in the rails mailer preview.