LG-11799: Remove same_address_as_id from analytics

app/controllers/concerns/idv/verify_info_concern.rb

@@ -195,11 +195,10 @@ def async_state_done(current_async_state)
             [:proofing_results, :context, :stages, :resolution, :errors, :ssn],
             [:proofing_results, :context, :stages, :residential_address, :errors, :ssn],
             [:proofing_results, :context, :stages, :threatmetrix, :response_body, :first_name],
-            [:same_address_as_id],
             [:proofing_results, :context, :stages, :state_id, :state_id_jurisdiction],
             [:proofing_results, :biographical_info, :identity_doc_address_state],
             [:proofing_results, :biographical_info, :state_id_jurisdiction],
-            [:proofing_results, :biographical_info, :same_address_as_id],
+            [:proofing_results, :biographical_info],
           ],
         },
       )
@@ -291,7 +290,12 @@ def idv_result_to_form_response(
       FormResponse.new(
         success: result[:success],
         errors: result[:errors],
-        extra: extra.merge(proofing_results: result.except(:errors, :success)),
+        extra: extra.merge(
+          proofing_results: {
+            **result.except(:errors, :success),
+            biographical_info: result[:biographical_info]&.except(:same_address_as_id),
+          },
+        ),
       )
     end
 

app/controllers/concerns/idv_step_concern.rb

@@ -78,18 +78,11 @@ def confirm_hybrid_handoff_needed
   private
 
   def extra_analytics_properties
-    extra = {
+    {
       pii_like_keypaths: [
-        [:same_address_as_id],
         [:proofing_results, :context, :stages, :state_id, :state_id_jurisdiction],
       ],
     }
-
-    unless flow_session.dig(:pii_from_user, :same_address_as_id).nil?
-      extra[:same_address_as_id] =
-        flow_session[:pii_from_user][:same_address_as_id].to_s == 'true'
-    end
-    extra
   end
 
   def letter_recently_enqueued?

app/services/analytics_events.rb

@@ -1481,7 +1481,6 @@ def idv_doc_auth_link_sent_visited(
   # @param [String] step Current IdV step
   # @param [String] analytics_id Current IdV flow identifier
   # @param ["hybrid","standard"] flow_path Document capture user flow
-  # @param [Boolean] same_address_as_id
   # @param [Boolean] skip_hybrid_handoff Whether skipped hybrid handoff A/B test is active
   # @param [Boolean] opted_in_to_in_person_proofing User opted into in person proofing
   # @param [Number] previous_ssn_edit_distance The edit distance to the previous submitted SSN
@@ -1491,7 +1490,6 @@ def idv_doc_auth_redo_ssn_submitted(
     flow_path:,
     opted_in_to_in_person_proofing: nil,
     skip_hybrid_handoff: nil,
-    same_address_as_id: nil,
     previous_ssn_edit_distance: nil,
     **extra
   )
@@ -1502,7 +1500,6 @@ def idv_doc_auth_redo_ssn_submitted(
       flow_path:,
       opted_in_to_in_person_proofing:,
       skip_hybrid_handoff:,
-      same_address_as_id:,
       previous_ssn_edit_distance:,
       **extra,
     )
@@ -1542,7 +1539,6 @@ def idv_doc_auth_socure_webhook_received(
   # @param ["hybrid","standard"] flow_path Document capture user flow
   # @param [String] acuant_sdk_upgrade_ab_test_bucket A/B test bucket for Acuant document capture
   # @param [Boolean] skip_hybrid_handoff Whether skipped hybrid handoff A/B test is active
-  # @param [Boolean] same_address_as_id
   # @param [Boolean] opted_in_to_in_person_proofing User opted into in person proofing
   # @param [Number] previous_ssn_edit_distance The edit distance to the previous submitted SSN
   def idv_doc_auth_ssn_submitted(
@@ -1555,7 +1551,6 @@ def idv_doc_auth_ssn_submitted(
     error_details: nil,
     acuant_sdk_upgrade_ab_test_bucket: nil,
     skip_hybrid_handoff: nil,
-    same_address_as_id: nil,
     previous_ssn_edit_distance: nil,
     **extra
   )
@@ -1570,7 +1565,6 @@ def idv_doc_auth_ssn_submitted(
       acuant_sdk_upgrade_ab_test_bucket:,
       flow_path:,
       opted_in_to_in_person_proofing:,
-      same_address_as_id:,
       previous_ssn_edit_distance:,
       **extra,
     )
@@ -1583,7 +1577,6 @@ def idv_doc_auth_ssn_submitted(
   # @param ["hybrid","standard"] flow_path Document capture user flow
   # @param [String] acuant_sdk_upgrade_ab_test_bucket A/B test bucket for Acuant document capture
   # @param [Boolean] skip_hybrid_handoff Whether skipped hybrid handoff A/B test is active
-  # @param [Boolean] same_address_as_id
   # @param [Boolean] opted_in_to_in_person_proofing User opted into in person proofing
   # @param [Number] previous_ssn_edit_distance The edit distance to the previous submitted SSN
   def idv_doc_auth_ssn_visited(
@@ -1593,7 +1586,6 @@ def idv_doc_auth_ssn_visited(
     opted_in_to_in_person_proofing: nil,
     acuant_sdk_upgrade_ab_test_bucket: nil,
     skip_hybrid_handoff: nil,
-    same_address_as_id: nil,
     previous_ssn_edit_distance: nil,
     **extra
   )
@@ -1605,7 +1597,6 @@ def idv_doc_auth_ssn_visited(
       acuant_sdk_upgrade_ab_test_bucket:,
       flow_path:,
       opted_in_to_in_person_proofing:,
-      same_address_as_id:,
       previous_ssn_edit_distance:,
       **extra,
     )
@@ -1892,7 +1883,6 @@ def idv_doc_auth_verify_polling_wait_visited(**extra)
   # @param flow_path [String] "hybrid" for hybrid handoff, "standard" otherwise
   # @param lexisnexis_instant_verify_workflow_ab_test_bucket [String] A/B test bucket for Lexis Nexis InstantVerify workflow testing
   # @param opted_in_to_in_person_proofing [Boolean] Whether this user explicitly opted into in-person proofing
-  # @param [Boolean] same_address_as_id
   # @param proofing_results [Hash]
   # @option proofing_results [String,nil] exception If an exception occurred during any phase of proofing its message is provided here
   # @option proofing_results [Boolean] timed_out true if any vendor API calls timed out during proofing
@@ -1964,7 +1954,6 @@ def idv_doc_auth_verify_proofing_results(
     ssn_is_unique: nil,
     step: nil,
     success: nil,
-    same_address_as_id: nil,
     previous_ssn_edit_distance: nil,
     **extra
   )
@@ -1984,7 +1973,6 @@ def idv_doc_auth_verify_proofing_results(
       ssn_is_unique:,
       step:,
       success:,
-      same_address_as_id:,
       previous_ssn_edit_distance:,
       **extra,
     )
@@ -1998,7 +1986,6 @@ def idv_doc_auth_verify_proofing_results(
   # @param ["hybrid","standard"] flow_path Document capture user flow
   # @param [String] acuant_sdk_upgrade_ab_test_bucket A/B test bucket for Acuant document capture
   # @param [Boolean] skip_hybrid_handoff Whether skipped hybrid handoff A/B test is active
-  # @param [Boolean] same_address_as_id
   # @param [Boolean] opted_in_to_in_person_proofing User opted into in person proofing
   def idv_doc_auth_verify_submitted(
     step:,
@@ -2007,7 +1994,6 @@ def idv_doc_auth_verify_submitted(
     opted_in_to_in_person_proofing: nil,
     acuant_sdk_upgrade_ab_test_bucket: nil,
     skip_hybrid_handoff: nil,
-    same_address_as_id: nil,
     **extra
   )
     track_event(
@@ -2018,7 +2004,6 @@ def idv_doc_auth_verify_submitted(
       acuant_sdk_upgrade_ab_test_bucket:,
       flow_path:,
       opted_in_to_in_person_proofing:,
-      same_address_as_id:,
       **extra,
     )
   end
@@ -2030,7 +2015,6 @@ def idv_doc_auth_verify_submitted(
   # @param ["hybrid","standard"] flow_path Document capture user flow
   # @param [String] acuant_sdk_upgrade_ab_test_bucket A/B test bucket for Acuant document capture
   # @param [Boolean] skip_hybrid_handoff Whether skipped hybrid handoff A/B test is active
-  # @param [Boolean] same_address_as_id
   # @param [Boolean] opted_in_to_in_person_proofing User opted into in person proofing
   def idv_doc_auth_verify_visited(
     step:,
@@ -2039,7 +2023,6 @@ def idv_doc_auth_verify_visited(
     opted_in_to_in_person_proofing: nil,
     acuant_sdk_upgrade_ab_test_bucket: nil,
     skip_hybrid_handoff: nil,
-    same_address_as_id: nil,
     **extra
   )
     track_event(
@@ -2050,7 +2033,6 @@ def idv_doc_auth_verify_visited(
       acuant_sdk_upgrade_ab_test_bucket:,
       flow_path:,
       opted_in_to_in_person_proofing:,
-      same_address_as_id:,
       **extra,
     )
   end
@@ -2761,7 +2743,6 @@ def idv_in_person_prepare_visited(flow_path:, opted_in_to_in_person_proofing:, *
   # @param [String] step
   # @param [String] analytics_id
   # @param [Boolean] skip_hybrid_handoff Whether skipped hybrid handoff A/B test is active
-  # @param [Boolean] same_address_as_id
   # @param [Boolean] opted_in_to_in_person_proofing User opted into in person proofing
   # address page visited
   def idv_in_person_proofing_address_visited(
@@ -2770,7 +2751,6 @@ def idv_in_person_proofing_address_visited(
     analytics_id:,
     opted_in_to_in_person_proofing: nil,
     skip_hybrid_handoff: nil,
-    same_address_as_id: nil,
     **extra
   )
     track_event(
@@ -2780,7 +2760,6 @@ def idv_in_person_proofing_address_visited(
       analytics_id:,
       opted_in_to_in_person_proofing:,
       skip_hybrid_handoff:,
-      same_address_as_id:,
       **extra,
     )
   end
@@ -2861,7 +2840,6 @@ def idv_in_person_proofing_nontransliterable_characters_submitted(
   # @param [String] step Current IdV step
   # @param [String] analytics_id Current IdV flow identifier
   # @param [Boolean] skip_hybrid_handoff Whether skipped hybrid handoff A/B test is active
-  # @param [Boolean, nil] same_address_as_id
   # @param [String] current_address_zip_code ZIP code of given address
   # @param [Boolean] opted_in_to_in_person_proofing User opted into in person proofing
   def idv_in_person_proofing_residential_address_submitted(
@@ -2874,7 +2852,6 @@ def idv_in_person_proofing_residential_address_submitted(
     opted_in_to_in_person_proofing: nil,
     error_details: nil,
     skip_hybrid_handoff: nil,
-    same_address_as_id: nil,
     **extra
   )
     track_event(
@@ -2888,7 +2865,6 @@ def idv_in_person_proofing_residential_address_submitted(
       opted_in_to_in_person_proofing:,
       error_details:,
       skip_hybrid_handoff:,
-      same_address_as_id:,
       **extra,
     )
   end
@@ -2899,7 +2875,6 @@ def idv_in_person_proofing_residential_address_submitted(
   # @param [Boolean] success Whether form validation was successful
   # @param [Hash] errors Errors resulting from form validation
   # @param [Hash] error_details Details for errors that occurred in unsuccessful submission
-  # @param [Boolean, nil] same_address_as_id
   # @param [Boolean] opted_in_to_in_person_proofing User opted into in person proofing
   # @param [String] birth_year Birth year from document
   # @param [String] document_zip_code ZIP code from document
@@ -2915,7 +2890,6 @@ def idv_in_person_proofing_state_id_submitted(
     document_zip_code:,
     skip_hybrid_handoff: nil,
     error_details: nil,
-    same_address_as_id: nil,
     opted_in_to_in_person_proofing: nil,
     **extra
   )
@@ -2930,7 +2904,6 @@ def idv_in_person_proofing_state_id_submitted(
       birth_year:,
       document_zip_code:,
       skip_hybrid_handoff:,
-      same_address_as_id:,
       opted_in_to_in_person_proofing:,
       **extra,
     )
@@ -2940,7 +2913,6 @@ def idv_in_person_proofing_state_id_submitted(
   # @param [String] step
   # @param [String] analytics_id
   # @param [Boolean] opted_in_to_in_person_proofing User opted into in person proofing
-  # @param [Boolean] same_address_as_id
   # @param [Boolean] skip_hybrid_handoff Whether skipped hybrid handoff A/B test is active
   # State id page visited
   def idv_in_person_proofing_state_id_visited(
@@ -2949,7 +2921,6 @@ def idv_in_person_proofing_state_id_visited(
     analytics_id: nil,
     opted_in_to_in_person_proofing: nil,
     skip_hybrid_handoff: nil,
-    same_address_as_id: nil,
     **extra
   )
     track_event(
@@ -2959,7 +2930,6 @@ def idv_in_person_proofing_state_id_visited(
       analytics_id:,
       opted_in_to_in_person_proofing:,
       skip_hybrid_handoff:,
-      same_address_as_id:,
       **extra,
     )
   end

app/services/idv/flows/in_person_flow.rb

@@ -36,17 +36,11 @@ def self.session_idv(session)
       end
 
       def extra_analytics_properties
-        extra = {
+        {
           pii_like_keypaths: [
-            [:same_address_as_id],
             [:proofing_results, :context, :stages, :state_id, :state_id_jurisdiction],
           ],
         }
-        unless @flow_session[:pii_from_user]&.[](:same_address_as_id).nil?
-          extra[:same_address_as_id] =
-            @flow_session[:pii_from_user][:same_address_as_id].to_s == 'true'
-        end
-        extra
       end
     end
   end

spec/controllers/idv/in_person/address_controller_spec.rb

@@ -59,7 +59,6 @@
         analytics_id: 'In Person Proofing',
         flow_path: 'standard',
         step: 'address',
-        same_address_as_id: false,
       }
     end
 
@@ -124,7 +123,6 @@
           analytics_id: 'In Person Proofing',
           flow_path: 'standard',
           step: 'address',
-          same_address_as_id: false,
           current_address_zip_code: '59010',
         }
       end
@@ -206,7 +204,6 @@
           analytics_id: 'In Person Proofing',
           flow_path: 'standard',
           step: 'address',
-          same_address_as_id: false,
           current_address_zip_code: '59010',
         }
       end

spec/controllers/idv/in_person/ssn_controller_spec.rb

@@ -42,7 +42,6 @@
         analytics_id: 'In Person Proofing',
         flow_path: 'standard',
         step: 'ssn',
-        same_address_as_id: true,
       }
     end
 
@@ -112,7 +111,6 @@
           step: 'ssn',
           success: true,
           errors: {},
-          same_address_as_id: true,
         }
       end
 
@@ -150,7 +148,6 @@
             step: 'ssn',
             success: true,
             previous_ssn_edit_distance: 6,
-            same_address_as_id: true,
             errors: {},
           }
         end
@@ -178,7 +175,6 @@
             ssn: ['Enter a nine-digit Social Security number'],
           },
           error_details: { ssn: { invalid: true } },
-          same_address_as_id: true,
         }
       end
 

spec/controllers/idv/in_person/state_id_controller_spec.rb

@@ -146,7 +146,6 @@
           analytics_id: 'In Person Proofing',
           flow_path: 'standard',
           step: 'state_id',
-          same_address_as_id: true,
           birth_year: dob[:year],
           document_zip_code: identity_doc_zipcode&.slice(0, 5),
         }

spec/controllers/idv/in_person/verify_info_controller_spec.rb

@@ -73,7 +73,6 @@
           analytics_id: 'In Person Proofing',
           flow_path: 'standard',
           step: 'verify',
-          same_address_as_id: true,
         },
       )
     end
@@ -136,7 +135,6 @@
               analytics_id: 'In Person Proofing',
               flow_path: 'standard',
               step: 'verify',
-              same_address_as_id: true,
             },
           ),
         )