LG-11799: Remove same_address_as_id from analytics

[eileen-nava]

🎫 Ticket

LG-11799: Remove same_address_as_id from analytics

🛠 Summary of changes

• The boolean value same_address_as_id no longer needs to be tracked in analytics. Consequently, this PR removes it.

📜 Testing Plan

I would recommend relying on automated specs for this PR. That being said, here's a manual testing plan.

• Locally run make watch_events
• Begin the in-person proofing process and navigate to the state id page
• Select that you live at a different address than your id's address and navigate to the next page.
• Inspect the output from make watch_events and confirm that none of the logs include same_address_as_id

[aduth]

Does this mutate the original result value in a way that might cause other side-effects? Is it something where we could either avoid assigning same_address_as_id into that result in the first place if it's not needed, or create a copy if this is being deleted to avoid including in extra?

e.g.

extra: extra.merge(
  proofing_results: {
    **result.except(:errors, :success),
    biographical_info: result[:biographical_info].except(:same_address_as_id),
  },
)

[eileen-nava]

@aduth See commit 20958fe.

[shanechesnutt-ft]

Ran through the test plan and everything looked good! 👍🏻