Fix migration check method call arguments#11388
Merged
mitchellhenke merged 1 commit intomainfrom Oct 23, 2024
Merged
Conversation
zachmargolis
approved these changes
Oct 23, 2024
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, worth adding a spec that calls this rake task?
changelog: Bug Fixes, Database, Fix migration check method call arguments
aduth
approved these changes
Oct 23, 2024
mitchellhenke
force-pushed
the
mitchellhenke/fix-migration-check
branch
from
81cd81d to
2661d05
Compare
Contributor
Author
Yep, just added Edit: and confirmed it also fails as expected without the change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
#11357 updated a deprecated method, but it no longer takes arguments. This addresses it by removing the argument.
Error: