Skip to content

Update Rails to 7.2.1.1#11357

Merged
aduth merged 9 commits intomainfrom
aduth-rails-7-4-1-1
Oct 23, 2024
Merged

Update Rails to 7.2.1.1#11357
aduth merged 9 commits intomainfrom
aduth-rails-7-4-1-1

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Oct 17, 2024

🛠 Summary of changes

Updates Rails from 7.1.4.1 to 7.2.1.1.

CHANGELOG:

Edit: This was originally targeted at resolving security advisories, but this was addressed separately in an incremental update in #11358.

📜 Testing Plan

Verify that build passes and application runs without warnings or errors.

@aduth
Copy link
Contributor Author

aduth commented Oct 17, 2024

The upgrade to 7.2 was more involved than first expected, specifically due to removals of deprecations, notably the removal of preview_path= from ActionMailer (which also affected dependency rspec-rails), as well as deprecated removal of ActiveRecord::Migration.check_pending!.

I reviewed all "Removals" and "Deprecations" from the 7.2 release notes to check for anything that might affect us, but would suggest reviewers do the same.

@aduth
Copy link
Contributor Author

aduth commented Oct 22, 2024

Failing test for lib/data_pull.rb appears to be affected by this change: https://blog.saeloun.com/2024/05/30/rails-7-2-pg-adapter-to-type-cast-date/

@aduth aduth force-pushed the aduth-rails-7-4-1-1 branch from 99a4ede to 4a3bb38 Compare October 22, 2024 12:45
@aduth aduth force-pushed the aduth-rails-7-4-1-1 branch from 4a3bb38 to c3501f8 Compare October 23, 2024 11:51
@aduth aduth force-pushed the aduth-rails-7-4-1-1 branch from c3501f8 to a8d3c4f Compare October 23, 2024 12:26
@aduth
Copy link
Contributor Author

aduth commented Oct 23, 2024

I tried to include another bundle update rails to catch transitive dependency updates, but there were a lot of failing specs (see build). Not clear which of the dependencies caused the issue, but I reverted back to the original Gemfile.lock updates and rebased against main.

For posterity, the changes attempted are reflected here: https://github.com/18f/identity-idp/compare/834aaf62b86e75faf6076524bc2eac66ac8f7baf..68eba3effc8a84d7d3c5e52927fdc4ba268de2ba

@mitchellhenke
Copy link
Contributor

I tried to include another bundle update rails to catch transitive dependency updates, but there were a lot of failing specs (see build). Not clear which of the dependencies caused the issue, but I reverted back to the original Gemfile.lock updates and rebased against main.

For posterity, the changes attempted are reflected here: https://github.com/18f/identity-idp/compare/834aaf62b86e75faf6076524bc2eac66ac8f7baf..68eba3effc8a84d7d3c5e52927fdc4ba268de2ba

If I were a betting person, the rack update is the one I'd think might be the issue.

@aduth aduth merged commit f7fcb4c into main Oct 23, 2024
@aduth aduth deleted the aduth-rails-7-4-1-1 branch October 23, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants