Skip to content

LG-13006: remove instances of skip_doc_auth - step 4/6 #11338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KeithNava merged 27 commits into from
Oct 25, 2024
Merged

LG-13006: remove instances of skip_doc_auth - step 4/6 #11338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
90b304f
feat: remove instances of skip_doc_auth
KeithNava Aug 7, 2024
d7c5fc6
changelog: Internal, In-person proofing, remove old skip_doc_auth var…
KeithNava Aug 8, 2024
9d897fa
feat: remove skip_doc_auth from hybrid handoff
KeithNava Aug 8, 2024
6971de0
feat: fix linting
KeithNava Aug 9, 2024
bc29ada
feat: update selected_remote helper method
KeithNava Aug 13, 2024
9bc612b
feat: add proper variables from session
KeithNava Aug 15, 2024
a7bbf83
feat: update new variable on the frontend
KeithNava Aug 19, 2024
1577da1
feat: lintfix
KeithNava Aug 19, 2024
443954e
feat: more lintfixes
KeithNava Aug 19, 2024
fd4fe47
feat: remove skip_doc_auth_from_handoff in controller
KeithNava Sep 11, 2024
568f27e
feat: update checks for hybrid_handoff controller
KeithNava Sep 12, 2024
268a6ac
feat: revert removal of skip_doc_auth from how to verify controller
KeithNava Oct 1, 2024
b7a49b4
feat: more updates to how_to_verify controller
KeithNava Oct 1, 2024
b550f80
feat: lintfix
KeithNava Oct 1, 2024
578afc1
feat: remove skipDocAuth from comment
KeithNava Oct 2, 2024
2dcf5dd
feat: add back old var for 50/50 testing
KeithNava Oct 8, 2024
eb4d7b1
feat: lintfix
KeithNava Oct 8, 2024
95f76cd
feat: revert removal of skip_doc_auth
KeithNava Oct 9, 2024
e5e530f
feat: updates to utilize skipDocAuth in flow along side skipDocAuthFr…
KeithNava Oct 10, 2024
eea6b8d
feat: lint fix
KeithNava Oct 10, 2024
d205e6d
feat: pull out space and line updates
KeithNava Oct 15, 2024
0d63ab7
fix: another whitespace fix
KeithNava Oct 15, 2024
4b99c60
space fix
KeithNava Oct 15, 2024
0956cc7
fix: another whitespace line fix
KeithNava Oct 15, 2024
634a171
feat: sync up with git
KeithNava Oct 15, 2024
cc50716
lintfix
KeithNava Oct 15, 2024
e1444f1
feat: lintfix
KeithNava Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/controllers/idv/hybrid_handoff_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,11 @@ def self.selected_remote(idv_session:)
if IdentityConfig.store.in_person_proofing_opt_in_enabled &&
Copy link
Copy Markdown
Contributor

@eileen-nava eileen-nava Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KeithNava, I am confused about what’s being displayed in “Files changed” section of this PR. When I look at the code on this branch locally, I see your changes to HowToVerifyController. But the HowToVerifyController doesn’t show up in the “Files changed” section of this PR.

However, if I navigate to the keithw/LG-13006-rename-skip-doc-auth-value branch and look at the HowToVerifyController, I see your commit 58d401d  from four days ago. Link here.

Any ideas what might have caused this? It has me scratching my head. 🤔

Copy link
Copy Markdown
Contributor Author

@KeithNava KeithNava Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eileen-nava I'm not exactly sure what happening there but I created a few commits around whitespacing to try and 'trick' git into not noticing a diff.

IdentityConfig.store.in_person_proofing_enabled &&
idv_session.service_provider&.in_person_proofing_enabled
idv_session.skip_doc_auth == false
idv_session.skip_doc_auth_from_how_to_verify == false ||
idv_session.skip_doc_auth == false
else
idv_session.skip_doc_auth.nil? ||
idv_session.skip_doc_auth_from_how_to_verify.nil? ||
idv_session.skip_doc_auth_from_how_to_verify == false || idv_session.skip_doc_auth.nil? ||
idv_session.skip_doc_auth == false
end
end
Expand Down
15 changes: 10 additions & 5 deletions app/javascript/packages/document-capture/components/document-capture.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,13 @@ function DocumentCapture({ onStepChange = () => {} }: DocumentCaptureProps) {
const { flowPath } = useContext(UploadContext);
const { trackSubmitEvent, trackVisitEvent } = useContext(AnalyticsContext);
const { isSelfieCaptureEnabled } = useContext(SelfieCaptureContext);
const { inPersonFullAddressEntryEnabled, inPersonURL, skipDocAuth, skipDocAuthFromHandoff } =
useContext(InPersonContext);
const {
inPersonFullAddressEntryEnabled,
inPersonURL,
skipDocAuth,
skipDocAuthFromHandoff,
skipDocAuthFromHowToVerify,
} = useContext(InPersonContext);
useDidUpdateEffect(onStepChange, [stepName]);
useEffect(() => {
if (stepName) {
Expand Down Expand Up @@ -135,9 +140,9 @@ function DocumentCapture({ onStepChange = () => {} }: DocumentCaptureProps) {
if (submissionError && formValues) {
initialValues = formValues;
}
// If the user got here by opting-in to in-person proofing, when skipDocAuth === true,
// If the user got here by opting-in to in-person proofing, when skipDocAuthFromHowToVerify === true || skipDocAuth === true,
// then set steps to inPersonSteps
const isInPersonStepEnabled = skipDocAuth || skipDocAuthFromHandoff;
const isInPersonStepEnabled = skipDocAuthFromHowToVerify || skipDocAuthFromHandoff || skipDocAuth;
const inPersonSteps: FormStep[] =
inPersonURL === undefined
? []
Expand All @@ -151,7 +156,7 @@ function DocumentCapture({ onStepChange = () => {} }: DocumentCaptureProps) {
} else if (submissionError) {
steps = [reviewFormStep, ...inPersonSteps];
}
// If the user got here by opting-in to in-person proofing, when skipDocAuth === true;
// If the user got here by opting-in to in-person proofing, when skipDocAuthFromHowToVerify === true || skipDocAuth === true;
// or opting-in ipp from handoff page, and selfie is required, when skipDocAuthFromHandoff === true
// then set stepIndicatorPath to VerifyFlowPath.IN_PERSON
const stepIndicatorPath =
Expand Down
3 changes: 2 additions & 1 deletion app/javascript/packages/document-capture/components/in-person-prepare-step.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ function InPersonPrepareStep({ toPreviousStep }) {
inPersonOutageMessageEnabled,
inPersonOutageExpectedUpdateDate,
skipDocAuth,
skipDocAuthFromHowToVerify,
skipDocAuthFromHandoff,
howToVerifyURL,
previousStepURL,
Expand All @@ -29,7 +30,7 @@ function InPersonPrepareStep({ toPreviousStep }) {
if (skipDocAuthFromHandoff && previousStepURL) {
// directly from handoff page
forceRedirect(previousStepURL);
} else if (skipDocAuth && howToVerifyURL) {
} else if ((skipDocAuthFromHowToVerify || skipDocAuth) && howToVerifyURL) {
forceRedirect(howToVerifyURL);
} else {
toPreviousStep();
Expand Down
7 changes: 7 additions & 0 deletions app/javascript/packages/document-capture/context/in-person.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,13 @@ export interface InPersonContextProps {
*/
skipDocAuth?: boolean;

/**
* When skipDocAuthFromHowToVerify is true and in_person_proofing_opt_in_enabled is true,
* users are directed to the beginning of the IPP flow. This is set to true when
* they choose Opt-in IPP on the new How To Verify page
*/
skipDocAuthFromHowToVerify?: boolean;

/**
* Flag set when user select IPP from handoff page when IPP is available
* and selfie is required
Expand Down
3 changes: 3 additions & 0 deletions app/javascript/packs/document-capture.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ interface AppRootData {
optedInToInPersonProofing: string;
securityAndPrivacyHowItWorksUrl: string;
skipDocAuth: string;
skipDocAuthFromHowToVerify: string;
skipDocAuthFromHandoff: string;
howToVerifyURL: string;
previousStepUrl: string;
Expand Down Expand Up @@ -106,6 +107,7 @@ const {
optedInToInPersonProofing,
usStatesTerritories = '',
skipDocAuth,
skipDocAuthFromHowToVerify,
skipDocAuthFromHandoff,
howToVerifyUrl,
previousStepUrl,
Expand Down Expand Up @@ -137,6 +139,7 @@ render(
optedInToInPersonProofing: optedInToInPersonProofing === 'true',
usStatesTerritories: parsedUsStatesTerritories,
skipDocAuth: skipDocAuth === 'true',
skipDocAuthFromHowToVerify: skipDocAuthFromHowToVerify === 'true',
skipDocAuthFromHandoff: skipDocAuthFromHandoff === 'true',
howToVerifyURL: howToVerifyUrl,
previousStepURL: previousStepUrl,
Expand Down