LG-13006: remove instances of skip_doc_auth - step 4/6

[KeithNava]

🎫 Ticket

Link to the relevant ticket:
LG-13006

🛠 Summary of changes

As a part of the effort of removing instances of the old variable skip_doc_auth, this PR addresses the need to ensure that the skip_doc_auth along with the new variable skip_doc_auth_from_how_to_verify are being used together in the appropriate decision points throughout the application. This is following the 50/50 state guidelines that highlighted in the handbook: https://handbook.login.gov/articles/manage-50-50-state.html#rename-a-field.

📜 Testing Plan

The main areas of impact are Doc Auth and Hybrid Handoff so testing the scenarios around those paths are most important.
Please see the previous PR for more details on the testing that was done: #11043

[aduth]

I don't think there's a need to handle 50/50 state with JavaScript files when used in this way.

In the case of a 50/50 deployment, each server would load a version of the JavaScript known to the server at the time that it was provisioned, either old or new. So it will load the "correct" version always.

[KeithNava]

Thank you @aduth , that does make a lot of sense!

[gina-yamada]

Can you add the additional line back in? No need to have this file show up in the diff list

[gina-yamada]

Can you add the additional line back in? No need to have this file show up in the diff list

[eileen-nava]

Hey @KeithNava, I am confused about what’s being displayed in “Files changed” section of this PR. When I look at the code on this branch locally, I see your changes to HowToVerifyController. But the HowToVerifyController doesn’t show up in the “Files changed” section of this PR.

However, if I navigate to the keithw/LG-13006-rename-skip-doc-auth-value branch and look at the HowToVerifyController, I see your commit 58d401d  from four days ago. Link here.

Any ideas what might have caused this? It has me scratching my head. 🤔

[KeithNava]

@eileen-nava I'm not exactly sure what happening there but I created a few commits around whitespacing to try and 'trick' git into not noticing a diff.

[gina-yamada]

I think it would be nice if you had a detailed testing plan. You mention doing a full regression of in person enrollment flow. You changed code in hybrid handoff and document capture but don't mention either.