Deploy RC 421 to Production#11337
Merged
zachmargolis merged 12 commits intostages/prodfrom Oct 10, 2024
Merged
Conversation
* LG-14389: Add analytics for consent screen email selection changelog: Upcoming Features, Partner Email Selection, Add analytics for consent screen email selection * Include needs_completion_screen_reason for submission event
* branch sharing * migration for comments * rake task * lg-14425 sensitive column updates changelog: Internal, Reporting,sensitive tag to all columns * delete yml file * update to spec * capture at execution * remove abort * update tests to exit * update tests to exit * update test output --------- Co-authored-by: Aaron Nagucki <aaron.nagucki@gmail.com>
* Increased version of @18f/identity-address-search * changelog: Internal, In-person proofing, Increased @18f/identity-address-search version number to next major version * Update changelog for address-search package * Update address-search changelog * Changed version to be minor rather than major
* Replace alt text on capture button with new alt text Changed the alt text to "Photo taken. Submit photo" * add changelog changelog: User-Facing Improvements, Doc Auth, change alt text to selfie green checkmark
* created socure_document_capture_controllers * created socure document request * created socure_document_capture show view * set up routing to work correctly Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov> Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov> Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
* socure document capture access behind feature flag [skip changelog] * add socure_enabled FF to socure document capture controllers * fix alphabetical order of config file
* Use a list to log resolved ACRs in events ### Why - Deter using the resolved ACRs directly in reporting. The resolved list of ACRs (or Vectors of Trust) is volatile and subject to relatively frequent change as service features are added, removed, or modified over time. Instead, most analytics users should use the resolved attribute flags (e.g., `facial_match` or `enhanced_ipp`) for event filtering. Going forward, the purpose of the `sp_request.component_values` field should be solely to support investigating unexpected behavior. - Eliminate unexpected "reformatting" or "truncation" of resolved ACR names. While truncating these strings makes composing queries simpler, it introduces complexity and confusion when triaging and debugging requests. Originally, the purpose was to be able to do simple filters like `properties.sp_request.component_values.Pb`, but with the deprecation of the VoT interfaces (and thereby the 2-character string names), the filter becomes ``sp_request.component_values.`urn:acr.login.gov:verified` ``, which is much less legible than: `'urn:acr.login.gov:verified' IN sp_request.component_names` - Why not store component values as a string? Basically, VoT/vtr style components and ACR style components "stringify" differently, which would make query composition even more complex, instead of less. ### How - Adds an array of strings containing the ACR name that will be stored in `sp_request.component_names`. - No other changes have been made to structure of `sp_request`. - New specs have been added for all IAL ACRs. changelog: Internal, Analytics, Streamlining inclusion of resolved ACR names resolves: https://gitlab.login.gov/lg-people/Melba/backlog-fy24/-/issues/112
…helm chart (#11125) * Swapping review apps to ArgoCD application and kustomize
* add failing spec * change database update strategy for account reset cancellation * Do not send notifications if request is not successful changelog: Bug Fixes, Account Reset, Fix race condition where concurrent requests to cancel could result in an exception * absorb NotifyUserOfRequestCancellation into PendingRequestForUser * Remove unused true/false return Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * remove unnecessary allowed extra analytics --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
* User-Facing Improvements, camera capture, update french text during camera capture * changelog: User-Facing Improvements, camera capture, update french text during camera capture * changelog: User-Facing Improvements, camera capture, update french text during camera capture
* LG-14397 Remove use_fed_domain_class config changelog: Internal, Configuration, Remove configuration not needed any longer * Fix incorrect example description * Add test for "email addresses" wihout domains
mitchellhenke
approved these changes
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features