Cuts over review app deployment to kustomize overlay/base instead of helm chart#11125
Cuts over review app deployment to kustomize overlay/base instead of helm chart#11125stephencshelton merged 46 commits intomainfrom
Conversation
…e database overrides
stephencshelton
force-pushed
the
sshelton/test-argo-kustomize
branch
from
b13df0b to
c210883
Compare
stephencshelton
changed the title
| - sed -i "s|{{ECR_REGISTRY}}|${ECR_REGISTRY}|g" ${APPLICATION_MANIFEST} | ||
| - cat ${APPLICATION_MANIFEST} | ||
| # Apply our ArgoCD Application | ||
| - kubectl apply -f ${APPLICATION_MANIFEST} -n argocd |
There was a problem hiding this comment.
can we add a thing that's like "watch your app here" to link to argo? would that be useful? i know we probably can't easily hook it up to do argocd app wait like for the other envs as easily, because the argo api token is currently protected to only run on main
There was a problem hiding this comment.
I mean nothing stopping us from adding that given we know the environment name, so we can generate the url based on that. Happy to add that if people think it would be good, would also like to throw the URL's as a comment on the MR eventually down the line so people don't have to go digging for them
There was a problem hiding this comment.
Alright added a line to help folks find their application in ArgoCD and check the progress
|
Hi just some feedback, the squashed merge commit for this PR didn't properly preserve the |
3 participants
🛠 Summary of changes
Swaps review app deployment to use kustomize base and overlays instead of the current helm chart, also swaps up the deployment/delete to happen through ArgoCD instead of using helm directly.