LG-14290- Add step indicator to How To Verify View - Fix Specs#11314
Merged
gina-yamada merged 1 commit intomainfrom Oct 4, 2024
Merged
LG-14290- Add step indicator to How To Verify View - Fix Specs#11314gina-yamada merged 1 commit intomainfrom
gina-yamada merged 1 commit intomainfrom
Conversation
12 tasks
aduth
approved these changes
Oct 4, 2024
Contributor
aduth
left a comment
There was a problem hiding this comment.
Nice, I hadn't seen that we had a "context" that was trying to do the human-readable sentence that I mentioned in my review comment, but I think your revisions here are much better for what I'd expect, since I wouldn't expect context to be used in that way 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-14290 Eng: Add step indicator component to Opt-in page (How to Verify)
🛠 Summary of changes
📜 Testing Plan
spec/views/idv/how_to_verify/show.html.erb_spec.rband check for readability (you can also look in screenshots)👀 Screenshots
Before:
After: