LG-14290- Add step indicator to How To Verify View#11298
Merged
gina-yamada merged 4 commits intomainfrom Oct 3, 2024
Merged
Conversation
…icator to how to verify view
KeithNava
approved these changes
Oct 1, 2024
Contributor
Author
|
Thanks @KeithNava for the review! |
jennyverdeyen
approved these changes
Oct 1, 2024
Contributor
jennyverdeyen
left a comment
There was a problem hiding this comment.
Testing steps all pass, code looks good to me!
Contributor
Author
|
@sumiat There are screenshots above in the description. Thank you |
shanechesnutt-ft
approved these changes
Oct 1, 2024
|
thanks @gina-yamada, looks good! |
aduth
reviewed
Oct 4, 2024
| end | ||
|
|
||
| context 'renders the show template with' do | ||
| it('a step indicator with Getting started as the current step') do |
Contributor
There was a problem hiding this comment.
Conventionally, we don't include parentheses for RSpec BDD methods.
I would also personally expect the "it" parameterization to read as a human-readable sentence. Currently it lacks a verb of what "it" is doing.
Suggested change
| it('a step indicator with Getting started as the current step') do | |
| it 'renders a step indicator with Getting started as the current step' do |
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
Updates merged in. Thanks for the review
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-14290 Eng: Add step indicator component to Opt-in page (How to Verify)
🛠 Summary of changes
📜 Testing Plan
in_person_proofing_opt_in_enabledandin_person_proofing_enabledidentity-idpandidentity-oidc-sinatrasevers. Enter Login vialocalhost:9292. Create an account. Step through the app to begin identity verification. Visit/verify/welcomeand then/verify/agreement. Open the console. Continue on. Next you will land on/verify/how_to_verify.Getting started/verify/how_to_verifyfrom a different path (not coming from/verify/agreement)- ie: Click the 'Cancel' link at the bottom and then click on button 'No, keep going'. Confirm step 3 - step 6 is working as expected./verify/how_to_verifyfrom a different path (not coming from/verify/agreement) - ie: Click the 'Continue in person' button. Once onverify/document_capture(Verify your identity in person), confirm the step nav changed. (Find a Post Office, Verify your information, Verify your phone number, Re-enter your password, Go to the Post Office). Then click the 'Back' link on this page. You should be on/verify/how_to_verifyagain. Confirm step 3 - step 6 is working as expected./verify/how_to_verifyin other paths not mentioned for step 2, 8 or 9. I don't think there are other paths but double check. Goal is to confirm there are no errors and the correct step is selected from any entry pointapp/controllers/idv/how_to_verify_controller.rband set@selfie_requiredto true in methodset_how_to_verify_presenter. Confirm Step nav displays on the page and that current step isGetting startedapp/controllers/idv/how_to_verify_controller.rband set@selfie_requiredto false in methodset_how_to_verify_presenter. Confirm Step nav displays on the page and that current step isGetting started👀 Screenshots
Before:
After:
After (Responsive):
After (Languages):
After (Biometrics):