Skip to content

LG-14392 Add doc_auth.headings.selfie_capture #11241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AShukla-GSA merged 1 commit into from
Sep 19, 2024
Merged

LG-14392 Add doc_auth.headings.selfie_capture #11241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/javascript/packages/document-capture/components/document-capture.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,12 @@ function DocumentCapture({ onStepChange = () => {} }: DocumentCaptureProps) {
const documentFormStep: FormStep = {
name: 'documents',
form: DocumentsStep,
title: t('doc_auth.headings.document_capture'), // might want to change title to isolated doc capture heading
title: t('doc_auth.headings.document_capture'),
};
const selfieFormStep: FormStep = {
name: 'selfie',
form: SelfieStep,
title: '', // TODO: replace with yml selfie_capture (Ticket LG-14392)
title: t('doc_auth.headings.selfie_capture'),
};
const documentsFormSteps: FormStep[] =
isSelfieCaptureEnabled && docAuthSeparatePagesEnabled && submissionError === undefined
Expand Down
1 change: 1 addition & 0 deletions config/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,7 @@ doc_auth.headings.no_ssn: Don’t have a Social Security number?
doc_auth.headings.review_issues: Check your images and try again
doc_auth.headings.secure_account: Secure your account
doc_auth.headings.selfie: Photo of your face
doc_auth.headings.selfie_capture: Capture photo of yourself
doc_auth.headings.ssn: Enter your Social Security number
doc_auth.headings.ssn_update: Update your Social Security number
doc_auth.headings.text_message: We sent a message to your phone
Expand Down
1 change: 1 addition & 0 deletions config/locales/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,7 @@ doc_auth.headings.no_ssn: '¿No tiene un número de Seguro Social?'
doc_auth.headings.review_issues: Revise sus imágenes e inténtelo de nuevo
doc_auth.headings.secure_account: Proteja su cuenta
doc_auth.headings.selfie: Fotografía de su cara
doc_auth.headings.selfie_capture: Capture una foto de usted
doc_auth.headings.ssn: Ingrese su número de Seguro Social
doc_auth.headings.ssn_update: Actualice su número de Seguro Social
doc_auth.headings.text_message: Enviamos un mensaje a su teléfono
Expand Down
1 change: 1 addition & 0 deletions config/locales/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,7 @@ doc_auth.headings.no_ssn: Vous n’avez pas de numéro de sécurité sociale ?
doc_auth.headings.review_issues: Vérifiez vos images et essayez à nouveau
doc_auth.headings.secure_account: Sécuriser votre compte
doc_auth.headings.selfie: Photo de votre visage
doc_auth.headings.selfie_capture: Prenez-vous en photo
doc_auth.headings.ssn: Saisir votre numéro de sécurité sociale
doc_auth.headings.ssn_update: Mettre à jour votre numéro de sécurité sociale
doc_auth.headings.text_message: Nous avons envoyé un message à votre téléphone
Expand Down
1 change: 1 addition & 0 deletions config/locales/zh.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,7 @@ doc_auth.headings.no_ssn: 没有社会保障号码？
doc_auth.headings.review_issues: 检查一下你的图片并再试一次
doc_auth.headings.secure_account: 保护你的账户安全
doc_auth.headings.selfie: 照片
doc_auth.headings.selfie_capture: 拍你本人照片
doc_auth.headings.ssn: 输入你的社会保障号码
doc_auth.headings.ssn_update: 更新你的社会保障号码
doc_auth.headings.text_message: 我们给你的手机发了短信
Expand Down
1 change: 1 addition & 0 deletions spec/features/idv/doc_auth/document_capture_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,7 @@
expect(page).not_to have_content(t('doc_auth.tips.document_capture_selfie_text1'))
attach_images
continue_doc_auth_form
expect(page).to have_title(t('doc_auth.headings.selfie_capture'))
Copy link
Copy Markdown
Contributor

@amirbey amirbey Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AShukla-GSA ... this could be an opportunity to add:

expect(page).to have_title(t('doc_auth.headings.document_capture')) # above line 499

expect(page).to have_content(t('doc_auth.tips.document_capture_selfie_text1'))
attach_selfie
submit_images
Expand Down