Skip to content

LG-14392 Add doc_auth.headings.selfie_capture#11241

Merged
AShukla-GSA merged 1 commit intomainfrom
lg-14392-add-selfie-capture-headings-title
Sep 19, 2024
Merged

LG-14392 Add doc_auth.headings.selfie_capture#11241
AShukla-GSA merged 1 commit intomainfrom
lg-14392-add-selfie-capture-headings-title

Conversation

@AShukla-GSA
Copy link
Contributor

@AShukla-GSA AShukla-GSA commented Sep 16, 2024

update capture heading to selfie step in for split doc auth

🎫 Ticket

Link to the relevant ticket:
LG-14392

🛠 Summary of changes

Added selfie capture heading translations and added title to selfie step for split doc auth

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Step 1 - Ensure your version of the app has doc_auth_separate_pages_enabled: true (application.yml)
  • Step 2 - Start with an oidc instance and select biometric vot (to go through doc auth flow with selfie)
  • Step 3 - Go through normal login doc auth flow until the selfie step
  • Step 4 - Ensure that the title on the tab (HTML <title>) is updated from "Add your ID" to "Capture photo of yourself"

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Before: Old Selfie Title
After: New Selfie Title

…e capture heading to selfie step in for split doc auth
@AShukla-GSA AShukla-GSA requested a review from solipet September 16, 2024 17:53
@amirbey
Copy link
Contributor

amirbey commented Sep 18, 2024

@AShukla-GSA - can you please update the title of this PR and provide a Testing Plan/Screenshots?

@AShukla-GSA AShukla-GSA changed the title changelog: User-Facing Improvements, form step titles, added new selfi… LG-14392 Add doc_auth.headings.selfie_capture Sep 19, 2024
@AShukla-GSA
Copy link
Contributor Author

@AShukla-GSA - can you please update the title of this PR and provide a Testing Plan/Screenshots?

Updated!

@amirbey amirbey self-requested a review September 19, 2024 18:56
@AShukla-GSA AShukla-GSA merged commit 48edf37 into main Sep 19, 2024
@AShukla-GSA AShukla-GSA deleted the lg-14392-add-selfie-capture-headings-title branch September 19, 2024 18:58
expect(page).not_to have_content(t('doc_auth.tips.document_capture_selfie_text1'))
attach_images
continue_doc_auth_form
expect(page).to have_title(t('doc_auth.headings.selfie_capture'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AShukla-GSA ... this could be an opportunity to add:

expect(page).to have_title(t('doc_auth.headings.document_capture')) # above line 499

AShukla-GSA added a commit that referenced this pull request Sep 30, 2024
…e capture heading to selfie step in for split doc auth (#11241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants