Fix expected analytics logging for DocAuth result#11223
Merged
Conversation
aduth
requested review from
a team and
jmax-gsa
and removed request for
a team
zachmargolis
approved these changes
Sep 10, 2024
aduth
force-pushed
the
aduth-image-upload-liveness
branch
from
548fbf1 to
40c59b4
Compare
changelog: Internal, Mock Proofer, Improve accuracy of mocker proofer analytics
aduth
force-pushed
the
aduth-image-upload-liveness
branch
from
40c59b4 to
aac5ea8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Implements suggestion from #11220 (comment) to unexempt
state_id_step_spec.rballowed extra analytics, fixing issues exposed:step_countis only included for FSM implementation, but is being removed in non-FSM approachstep_countfrom FSM with expectation that it's no longer needed📜 Testing Plan
Verify build passes.