Document analytics properties exempted in controller specs#11220
Merged
Conversation
changelog: Internal, Analytics, Document analytics properties
aduth
requested review from
a team,
eileen-nava and
solipet
and removed request for
a team
gina-yamada
reviewed
Sep 10, 2024
gina-yamada
reviewed
Sep 10, 2024
|
|
||
| def idv_in_person_proofing_residential_address_submitted(**extra) | ||
| track_event('IdV: in person proofing residential address submitted', **extra) | ||
| # @param [Boolean] success Whether form validation was successful |
Contributor
There was a problem hiding this comment.
NIt- I did not look at all events but it would be nice if the order matched ie: 3 arg in notes is error_details but is flow_path in args below. Update- maybe lots of additional work and not caused by your changes so ignore if you'd like
Contributor
Author
There was a problem hiding this comment.
I tried to add some consistency here while balancing diff size. I think we'll want to make a pass at standardizing order & descriptions once we've got everything fully documented
Contributor
There was a problem hiding this comment.
Make sense to me- resolving
matthinz
approved these changes
Sep 10, 2024
Contributor
matthinz
left a comment
matthinz
left a comment
There was a problem hiding this comment.
LGTM, thank you for your service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates controller specs to remove blanket exemptions for
allowed_extra_analytics, and adds documentation where existing errors occur in doing so.Most of these are in IdV/IPP.
Why?
allowed_extra_analytics📜 Testing Plan
Verify build passes.
Double-check that required keyword arguments are always passed.