Skip to content

LG-13135: rename submit_attempts_remaining #11219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solipet merged 1 commit into from
Sep 10, 2024
Merged

LG-13135: rename submit_attempts_remaining #11219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/idv/session_errors_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def log_event(based_on_limiter: nil)
type: params[:action],
}

options[:submit_attempts_remaining] = based_on_limiter.remaining_count if based_on_limiter
options[:remaining_submit_attempts] = based_on_limiter.remaining_count if based_on_limiter

analytics.idv_session_error_visited(**options)
end
Expand Down
9 changes: 5 additions & 4 deletions app/services/analytics_events.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4237,16 +4237,17 @@ def idv_selfie_image_clicked(

# Tracks when the user visits one of the the session error pages.
# @param [String] type
# @param [Integer,nil] submit_attempts_remaining (previously called "attempts_remaining")
# @param [Integer,nil] remaining_submit_attempts
# (previously called "attempts_remaining" and "submit_attempts_remaining")
def idv_session_error_visited(
type:,
submit_attempts_remaining: nil,
remaining_submit_attempts: nil,
**extra
)
track_event(
'IdV: session error visited',
type: type,
submit_attempts_remaining: submit_attempts_remaining,
type:,
remaining_submit_attempts:,
**extra,
)
end
Expand Down
8 changes: 4 additions & 4 deletions spec/controllers/idv/session_errors_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
'IdV: session error visited',
hash_including(
type: action.to_s,
submit_attempts_remaining: IdentityConfig.store.idv_max_attempts - 1,
remaining_submit_attempts: IdentityConfig.store.idv_max_attempts - 1,
),
)
end
Expand Down Expand Up @@ -271,7 +271,7 @@
'IdV: session error visited',
hash_including(
type: action.to_s,
submit_attempts_remaining: 0,
remaining_submit_attempts: 0,
),
)
end
Expand Down Expand Up @@ -313,7 +313,7 @@
'IdV: session error visited',
hash_including(
type: 'ssn_failure',
submit_attempts_remaining: 0,
remaining_submit_attempts: 0,
),
)
end
Expand Down Expand Up @@ -347,7 +347,7 @@
'IdV: session error visited',
hash_including(
type: action.to_s,
submit_attempts_remaining: 0,
remaining_submit_attempts: 0,
),
)
end
Expand Down