Skip to content

LG-13135: rename submit_attempts_remaining#11219

Merged
solipet merged 1 commit intomainfrom
dprice/lg-13135-rename-submit-attempts-remaining
Sep 10, 2024
Merged

LG-13135: rename submit_attempts_remaining#11219
solipet merged 1 commit intomainfrom
dprice/lg-13135-rename-submit-attempts-remaining

Conversation

@solipet
Copy link
Contributor

@solipet solipet commented Sep 9, 2024

🎫 Ticket

Link to the relevant ticket:
LG-13135

🛠 Summary of changes

Renames the symbol :submit_attempts_remaining to remaining_submit_attempts for consistency with the rest of the codebase.

@solipet solipet requested review from a team and amirbey and removed request for a team September 9, 2024 19:39
Copy link
Contributor

@theabrad theabrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AShukla-GSA AShukla-GSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (edit: looks like you need a changelog commit message)

Renames the symbol `:submit_attempts_remaining` to
`remaining_submit_attempts` for consistency with the rest of the
codebase.

[skip changelog]
@solipet solipet force-pushed the dprice/lg-13135-rename-submit-attempts-remaining branch from 81429bb to 05d9021 Compare September 10, 2024 13:54
@solipet solipet merged commit 70d8d0b into main Sep 10, 2024
@solipet solipet deleted the dprice/lg-13135-rename-submit-attempts-remaining branch September 10, 2024 15:43
@solipet
Copy link
Contributor Author

solipet commented Sep 10, 2024

The force-push after approvals was simply a correction on the commit message. No difference between commits in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants