Closed
Conversation
…celled in_person_enrollments
…lowing up for expired, failed, and cancelled in_person_enrollments
Contributor
|
Why not implement this in |
aduth
reviewed
Aug 26, 2024
Comment on lines
+66
to
+75
| in_person_enrollment = user&.in_person_enrollments&.first | ||
| if in_person_enrollment&.expired? | ||
| user.pending_in_person_enrollment.present? | ||
| elsif in_person_enrollment&.cancelled? | ||
| user.pending_in_person_enrollment.present? | ||
| elsif in_person_enrollment&.failed? | ||
| user.pending_in_person_enrollment.present? | ||
| else | ||
| !!user.pending_profile&.in_person_verification_pending? | ||
| end |
Contributor
There was a problem hiding this comment.
Maybe simpler option to check that the enrollment associated with the pending profile is explicitly pending?
Suggested change
| in_person_enrollment = user&.in_person_enrollments&.first | |
| if in_person_enrollment&.expired? | |
| user.pending_in_person_enrollment.present? | |
| elsif in_person_enrollment&.cancelled? | |
| user.pending_in_person_enrollment.present? | |
| elsif in_person_enrollment&.failed? | |
| user.pending_in_person_enrollment.present? | |
| else | |
| !!user.pending_profile&.in_person_verification_pending? | |
| end | |
| !!user.pending_profile&.in_person_enrollment&.pending? |
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback. 🙏🏻 I am going to close this PR because, as Gina mentioned here, Joy decided to backfill the data. This PR is no longer relevant.
(I am going to merge the regression specs in a separate PR.)
Contributor
Author
|
I am closing this PR because we decided to backfill the data. The change in AccountShowPresenter is no longer relevant. I will merge the regression specs in PR #11141. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.