Regression specs for users with cancelled and failed in_person_enrollments#11141
Merged
eileen-nava merged 5 commits intomainfrom Aug 29, 2024
Merged
Regression specs for users with cancelled and failed in_person_enrollments#11141eileen-nava merged 5 commits intomainfrom
eileen-nava merged 5 commits intomainfrom
Conversation
Closed
gina-yamada
reviewed
Aug 29, 2024
| # Make the in_person_enrollment and associated profile failed | ||
| in_person_enrollment = user.in_person_enrollments.first | ||
| in_person_enrollment.update!(status: :failed, status_check_completed_at: Time.zone.now) | ||
| end |
Contributor
There was a problem hiding this comment.
@eileen-nava For both, we need to update the profile as well. (You did this for expired below)
profile = user.profiles.first
profile.deactivate_due_to_in_person_verification_cancelled
Contributor
Author
There was a problem hiding this comment.
@gina-yamada Thanks for catching that! I fixed it in 9e19f4a.
Contributor
There was a problem hiding this comment.
Thanks for adding these specs.
gina-yamada
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes tests to catch bug where users with cancelled and failed in_person_enrollments can't access the account page.