Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

18F / identity-idp Public

Notifications You must be signed in to change notification settings
Fork 166
Star 578

Code
Issues 1
Pull requests 30
Projects
Wiki
Security and quality
Insights

Additional navigation options

Code
Issues
Pull requests
Projects
Wiki
Security and quality
Insights

Simplify RateLimiter to avoid handling expiration in code#10980

Closed

aduth wants to merge 10 commits intomain18F/identity-idp:mainfrom

aduth-rm-rate-limiter-check-expired18F/identity-idp:aduth-rm-rate-limiter-check-expiredCopy head branch name to clipboard

Conversation Commits10 (10)Checks Files changed

Closed

Simplify RateLimiter to avoid handling expiration in code#10980
aduth wants to merge 10 commits intomainfrom
aduth-rm-rate-limiter-check-expired

Commits

Commits on Jul 24, 2024

Simplify RateLimiter to avoid handling expiration in code
aduth
committed
Remove references to expires_at
aduth
committed
Restore local consideration of incremented expiration
aduth
committed
Restore expires_at with on-demand fetch
aduth
committed
Fetch expiration in attempted_at
aduth
committed
Try avoiding call to Redis as part of expired consideration
aduth
committed
Revert OtpRateLimiter changes
aduth
committed
Revert Idv::PhoneController spec changes
aduth
committed
Ensure expiretime fetched for direct calls to attempted_at
aduth
committed
Use consistent fetch pattern for attempts and expiration
aduth
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.