Simplify RateLimiter to avoid handling expiration in code#10980
Closed
Simplify RateLimiter to avoid handling expiration in code#10980
Conversation
changelog: Internal, Rate Limiting, Simplify RateLimiter to avoid handling expiration in code
Contributor
Author
|
One potential issue here is that we rely on a local expiration value when incrementing multiple times on the same instance, to avoid calling to Redis (related failing spec). We could keep some of the local expiration tracking for when incrementing while still removing the Redis |
Used in UI to show how long before the user can try again
Contributor
Author
|
Going to close this for now until some of the other rate-limit related changes settle in this class, specifically those in #10982. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates
RateLimiterto avoid handling expiration through code logic. Since we use Redis' built-in key expiration, we can infer expiration based on the absence of a key in the store.Draft: Clarify assumptions.
📜 Testing Plan
TBD