Skip to content

Add spec to ensure mailers don't include SVG #10949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Jul 17, 2024
Merged

Add spec to ensure mailers don't include SVG #10949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion spec/mailers/previews/user_mailer_preview_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,17 @@
RSpec.describe UserMailerPreview do
UserMailerPreview.instance_methods(false).each do |mailer_method|
describe "##{mailer_method}" do
subject(:mail) { UserMailerPreview.new.public_send(mailer_method) }

it 'generates a preview without blowing up' do
expect { UserMailerPreview.new.public_send(mailer_method).body }.to_not raise_error
expect { mail.body }.to_not raise_error
end

it 'does not include any svg images' do
# SVGs are typically the preferred format for their high-quality and small file size, but
# they are not well-supported in email clients. Instead, store a rasterized version of the
# image in `app/assets/images/email` for use in mailer content.
expect(mail.html_part.body).not_to have_selector("img[src$='.svg']")
end
end
end
Expand Down