Add spec to ensure mailers don't include SVG#10949
Merged
Conversation
changelog: Internal, Automated Testing, Add spec to ensure mailers don't include SVG
mitchellhenke
approved these changes
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Adds a test to verify that mailer content doesn't include SVG images. As described in the included inline code comment (and related folder README), SVG images are not well supported in mail clients. This is often hard to spot in development, since our HTML previews render correctly in a browser, but the mailer may not always show the expected content when sent in a deployed environment. The intent of the test is to reduce the feedback loop for this issue, and ensure that the issue is caught sooner.
Previously:
📜 Testing Plan
Verify that tests pass:
For bonus points, modify a file in
app/views/user_mailerto include an SVG image and verify that the same tests fail.