Merged
Conversation
* changelog: User-Facing Improvements, identity verification, Verified & Pending States for Identity Verification * add badges pertaining to verification status * add tooltip enabled component * add biometric verification to verified account view * add translated text * remove redundant key * change tooltip to use mouseover * clarify tooltip js and add testing * add spec for badge tooltip * move styling to badge tooltip * add readme to package * fix errors in yml * normalize yml * pinpoint countries * re-normalize yaml country codes * fix lint errors in badge scss's * remove unused keys * replace missing translation key * remove hardcoded app_name from translations * fix inconsistencies in verified button styling * remove unneeded css * add view tests for new badge placement * fix missing translated variable * adds tab event to tooltip. remove redundant status classes from badge border * refactor badges to incorporate an icon class * uncomplicate badge tab-into tooltip * add test coverage for changes to show_pii_partials? * direct help center articles links accordingly, fix conditional nesting in view * reformat formatted_due_date more succinctly * fix formatting regression with help center link, change tooltip to data- attribute * sync tooltip spec with data- attribute change * sync component spec with attribute change * remove data- prefix from tooltip-text * reset help_center links to use redirect * fix lint problems in erb file * possibly trailing space error affecting lint * mystery lint error * remove css class per change of style paradigm * add blank newline to end * lint error * Handle border and icon colors internal to BadgeComponent * Render stylesheet tag after component in preview Match application behavior See: #10394 (comment) * Sync badge component preview options * Remove unnecessary workaround for tooltip buttons See: https://github.com/18F/identity-idp/pull/10847/files#r1654791910 * Remove unused type: badge See: https://github.com/18F/identity-idp/pull/10847/files#r1654758970 * Assign tooltip classes internal to BadgeTooltipComponent * Add BadgeTooltipComponent preview * Render tag options on lg-badge-tooltip wrapper * Use default Tooltip component for tooltip behavior See: #10847 (comment) * Generalize BadgeTooltipCompponent as TooltipComponent * Use correct icons for verified badges * Handle additional IdV cases * Rearrange string keys for account verification content See: https://github.com/18F/identity-idp/pull/10847/files#r1654881240 * Include location parameters in help center redirect path help understand where the link was when the user clicked on it See: #10847 (comment) * Update specs * Fix spacing and indentation * Remove view rendering assertions from controller specs This is not a concern of the controller. View specs already validate this behavior. * reduce methods that are already memoized * replaced missing translation token * fix design system version dependency --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
LG-13848 | ActionAccount reinstated message When a user has already been reinstated, give a less-confusing error message. changelog: Internal, ActionAccount, Clear message when trying to reinstate a reinstated account
solipet
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal