Skip to content

LG-13848 | ActionAccount reinstated message#10927

Merged
n1zyy merged 2 commits intomainfrom
mattw/lg-13848_already_reinstated
Jul 10, 2024
Merged

LG-13848 | ActionAccount reinstated message#10927
n1zyy merged 2 commits intomainfrom
mattw/lg-13848_already_reinstated

Conversation

@n1zyy
Copy link
Contributor

@n1zyy n1zyy commented Jul 10, 2024

🎫 Ticket

Link to the relevant ticket:
LG-13848

🛠 Summary of changes

When a user is reinstated, for some reason the Cloudwatch log doesn't always show up. (This should be investigated separately!)

If the (employee) user tries to reinstate a user who has already been reinstated, let's give a clearer error message.

I have included a timestamp because that was helpful to Rebecca in digging into this yesterday, so let's just include that.

When a user has already been reinstated, give a less-confusing
error message.
@n1zyy n1zyy requested a review from a team July 10, 2024 15:10
Copy link
Contributor

@samathad2023 samathad2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@ThatSpaceGuy ThatSpaceGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks very much for the assist, @n1zyy!

Copy link
Contributor

@colter-nattrass colter-nattrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n1zyy n1zyy merged commit 299c05e into main Jul 10, 2024
@n1zyy n1zyy deleted the mattw/lg-13848_already_reinstated branch July 10, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants