LG-13318: Ensure user_id present in account deletion submitted event#10887
Merged
LG-13318: Ensure user_id present in account deletion submitted event#10887
Conversation
changelog: Internal, Analytics, Ensure user ID present in account deletion submitted
aduth
changed the title
mitchellhenke
approved these changes
Jun 28, 2024
The issue was stub_analytics was _also_ being called and causing the controller to memoize analytics result in a way that wasn't previously surfaced since we asserted against analytics_user directly, despite the fact that the analytics method is what's actually used in code for logging
aduth
commented
Jul 1, 2024
Signing out would cause current_user to always return nil. This change returns to previous implementation prior to #10573 with order of redirect See: https://github.com/18F/identity-idp/pull/10887/files#r1661091791
mdiarra3
approved these changes
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-13318
🛠 Summary of changes
Fixes analytics logging for account deletion event to ensure that the user ID is logged correctly
📜 Testing Plan
Verify you see
user_idin logged events after deleting an account:make watch_eventsin a separate terminal processmake watch_events, observe"Account Delete submitted"event includes a non-nilproperties.user_idSpec updates should provide regression assurance: