LG-13762: Derive proofing_components dynamically#10870
Merged
Conversation
Add new class, `ProofingComponents`, that calculates our sometimes-wonky ProofingComponents values based on values in Idv::Session. changelog: Internal, Identity verification, Calculate proofing_components dynamically
matthinz
force-pushed
the
matthinz/functional-proofing-components
branch
from
8a4191b to
5226e11
Compare
matthinz
commented
Jun 27, 2024
| end | ||
| end | ||
|
|
||
| def liveness_check |
Contributor
Author
There was a problem hiding this comment.
I don't necessarily think this should land with these unused methods in place, I just wanted to call out that the existing proofing_components infrastructure as some gaps (these columns exist in the DB but don't appear to be used)
Contributor
Author
There was a problem hiding this comment.
Created a coupla tickets (LG-13759 & LG-13760) around cleaning up these old columns
matthinz
commented
Jun 27, 2024
jmhooper
approved these changes
Jun 28, 2024
jmhooper
reviewed
Jun 28, 2024
matthinz
changed the title
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
zachmargolis
approved these changes
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-13762
(Originally started as an alternative way to accomplish the goals underlying LG-13121.)
🛠 Summary of changes
Historically we've stored
proofing_components(little bits of data about how the user has proofed) in a database table. The Rails model,ProofingComponenthas a 1:1 relationship withUser. This is a little awkward, since it is possible for a single user to attempt proofing more than once.This PR updates analytics logging that includes proofing components to calculate those components dynamically from the current
Idv::Session. The ultimate goal would be to remove writes to theproofing_components.📜 Testing Plan
Provide a checklist of steps to confirm the changes.
events.logproofing_componentsstill show up where they should