Fix 500 in document capture when going to IPP#10830
Merged
mitchellhenke merged 2 commits intomainfrom Jun 28, 2024
Merged
Conversation
eileen-nava
reviewed
Jun 20, 2024
| check_or_render_not_found -> { IdentityConfig.store.in_person_proofing_enabled } | ||
|
|
||
| before_action :handle_fraud | ||
| before_action :confirm_two_factor_authenticated |
Contributor
There was a problem hiding this comment.
The fix makes sense. Could you please add a test for it?
Contributor
Author
There was a problem hiding this comment.
Test added. It's a bit wonky since it requires a specific combination of configs
mitchellhenke
force-pushed
the
mitchellhenke/fix-500-in-ready-to-verify-ipp
branch
2 times, most recently
from
ab48723 to
d5ae868
Compare
added 2 commits
June 24, 2024 11:24
changelog: Bug Fixes, In-Person Proofing, Fix 500 in document capture when going to IPP
mitchellhenke
force-pushed
the
mitchellhenke/fix-500-in-ready-to-verify-ipp
branch
from
d5ae868 to
6a1e973
Compare
eileen-nava
approved these changes
Jun 24, 2024
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
Looks good, thanks Mitchell! 👏🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes a 500 from New Relic where
current_useris nil in thehandle_fraudmethods further up the stack by moving theconfirm_two_factor_authenticatedcheck to be first.