Skip to content

Update db/schema.rb to match migrations #10815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 1 commit into from
Jun 13, 2024
Merged

Update db/schema.rb to match migrations #10815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions db/schema.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
# These are extensions that must be enabled in order to support this database
enable_extension "citext"
enable_extension "pg_stat_statements"
enable_extension "pgcrypto"
Copy link
Copy Markdown
Contributor Author

@mitchellhenke mitchellhenke Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is left over from https://github.com/18F/identity-idp/pull/5275/files#diff-51a7a6164b57d05d4ec51d2c66b5fc9abb235f36f41ce2188cf9ab13c15bd256R4 since the GoodJob migration
 was originally in this folder.

enable_extension "plpgsql"

create_table "account_reset_requests", force: :cascade do |t|
Expand Down Expand Up @@ -318,7 +317,7 @@
t.boolean "ready_for_status_check", default: false
t.datetime "notification_sent_at", comment: "The time a notification was sent"
t.datetime "last_batch_claimed_at"
t.string "sponsor_id", comment: "The identification number for USPS to recognize us and our flow (ex: Enhanced IPP)"
Copy link
Copy Markdown
Contributor

@aduth aduth Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment was intentionally added based on review feedback, so the sync-up should probably have been to include the comment in the migration itself.

cc @KeithNava @eileen-nava

Copy link
Copy Markdown
Contributor Author

@mitchellhenke mitchellhenke Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment won't appear in the database in environments that have already run this migration, and I'm not sure how often we update migrations that have already been run (though a comment is maybe not over that line)

Copy link
Copy Markdown
Contributor

@aduth aduth Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I suppose if it's important to have the comment, a separate migration just to add the comment might be the way to go.

t.string "sponsor_id"
t.index ["profile_id"], name: "index_in_person_enrollments_on_profile_id"
t.index ["ready_for_status_check"], name: "index_in_person_enrollments_on_ready_for_status_check", where: "(ready_for_status_check = true)"
t.index ["status_check_attempted_at"], name: "index_in_person_enrollments_on_status_check_attempted_at", where: "(status = 1)"
Expand Down Expand Up @@ -657,7 +656,7 @@
add_foreign_key "iaa_gtcs", "partner_accounts"
add_foreign_key "iaa_orders", "iaa_gtcs"
add_foreign_key "in_person_enrollments", "profiles"
add_foreign_key "in_person_enrollments", "service_providers", column: "issuer", primary_key: "issuer"
add_foreign_key "in_person_enrollments", "service_providers", column: "issuer", primary_key: "issuer", validate: false
add_foreign_key "in_person_enrollments", "users"
add_foreign_key "integration_usages", "iaa_orders"
add_foreign_key "integration_usages", "integrations"
Expand Down