Skip to content

Remove dead code in the Idv::AddressController #10811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 1 commit into from
Jun 13, 2024
Merged

Remove dead code in the Idv::AddressController #10811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions app/controllers/idv/address_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ def update
@address_form = build_address_form
form_result = @address_form.submit(profile_params)
track_submit_event(form_result)
capture_address_edited(form_result)
if form_result.success?
success
else
Expand Down Expand Up @@ -69,8 +68,11 @@ def failure
end

def track_submit_event(form_result)
address_edited = form_result.success? && address_edited?
analytics.idv_address_submitted(**form_result.to_h.merge(address_edited:))
analytics.idv_address_submitted(
**form_result.to_h.merge(
address_edited: address_edited?,
),
)
end

def address_edited?
Expand All @@ -80,10 +82,5 @@ def address_edited?
def profile_params
params.require(:idv_form).permit(Idv::AddressForm::ATTRIBUTES)
end

def capture_address_edited(result)
address_edited = result.to_h[:address_edited]
idv_session.address_edited = true if address_edited
end
end
end
2 changes: 2 additions & 0 deletions app/forms/idv/address_form.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ def submit(params)
end

def updated_user_address
return nil unless valid?

Pii::Address.new(
address1: address1,
address2: address2,
Expand Down