Skip to content

LG-12295 | Adds TMX stats to DIVR #10741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n1zyy merged 3 commits into from
Jun 3, 2024
Merged

LG-12295 | Adds TMX stats to DIVR #10741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d49a952
LG-12295 | Report on TMX stats in DIVR
n1zyy May 31, 2024
d85282f
Merge branch 'main' into mattw/LG-12295_tmx_stats_in_divr
n1zyy May 31, 2024
18a4298
Better naming as suggested in PR
n1zyy May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/services/analytics_events.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1363,8 +1363,8 @@ def idv_enter_password_visited(
# @param [String, nil] deactivation_reason Reason user's profile was deactivated, if any.
# @param [Boolean] fraud_review_pending Profile is under review for fraud
# @param [Boolean] fraud_rejection Profile is rejected due to fraud
# @param [Boolean] gpo_verification_pending Profile is awaiting gpo verificaiton
# @param [Boolean] in_person_verification_pending Profile is awaiting in person verificaiton
# @param [Boolean] gpo_verification_pending Profile is awaiting gpo verification
# @param [Boolean] in_person_verification_pending Profile is awaiting in person verification
Copy link
Copy Markdown
Contributor Author

@n1zyy n1zyy May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pet peeve change while I was poking through here. 😇

# @param [Idv::ProofingComponentsLogging] proofing_components User's current proofing components
# @param [String,nil] active_profile_idv_level ID verification level of user's active profile.
# @param [String,nil] pending_profile_idv_level ID verification level of user's pending profile.
Expand Down
1 change: 1 addition & 0 deletions lib/reporting/identity_verification_report.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ def as_csv
csv << ['Workflow completed - In-Person Pending', idv_final_resolution_in_person]
csv << ['Workflow completed - Fraud Review Pending', idv_final_resolution_fraud_review]
csv << []
csv << ['Fraud review rejected', idv_fraud_rejected]
csv << ['Successfully Verified', successfully_verified_users]
csv << ['Successfully Verified - With phone number', idv_final_resolution_verified]
csv << ['Successfully Verified - With mailed code', gpo_verification_submitted]
Expand Down
12 changes: 11 additions & 1 deletion spec/lib/reporting/identity_verification_report_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
cloudwatch_client = double(
'Reporting::CloudwatchClient',
fetch: [
# Online verification user (failed each vendor once, then suceeded once)
# Online verification user (failed each vendor once, then succeeded once)
{ 'user_id' => 'user1', 'name' => 'IdV: doc auth welcome visited' },
{ 'user_id' => 'user1', 'name' => 'IdV: doc auth welcome submitted' },
{ 'user_id' => 'user1', 'name' => 'IdV: doc auth image upload vendor submitted', 'doc_auth_failed_non_fraud' => '1' },
Expand All @@ -38,6 +38,13 @@
{ 'user_id' => 'user3', 'name' => 'IdV: final resolution', 'fraud_review_pending' => '1' },
{ 'user_id' => 'user3', 'name' => 'Fraud: Profile review passed', 'success' => '1' },

# Fraud review user (rejected)
{ 'user_id' => 'user3', 'name' => 'IdV: doc auth welcome visited' },
{ 'user_id' => 'user3', 'name' => 'IdV: doc auth welcome submitted' },
{ 'user_id' => 'user3', 'name' => 'IdV: doc auth image upload vendor submitted', 'success' => '1' },
{ 'user_id' => 'user3', 'name' => 'IdV: final resolution', 'fraud_review_pending' => '1' },
{ 'user_id' => 'user3', 'name' => 'Fraud: Profile review rejected', 'success' => '1' },

# Success through address confirmation user
{ 'user_id' => 'user4', 'name' => 'IdV: GPO verification submitted' },
{ 'user_id' => 'user4', 'name' => 'Fraud: Profile review passed', 'success' => '1' },
Expand Down Expand Up @@ -79,6 +86,7 @@
['Workflow completed - In-Person Pending', 1],
['Workflow completed - Fraud Review Pending', 1],
[],
['Fraud review rejected', 1],
['Successfully Verified', 4],
['Successfully Verified - With phone number', 1],
['Successfully Verified - With mailed code', 1],
Expand Down Expand Up @@ -121,6 +129,7 @@
['Workflow completed - In-Person Pending', '1'],
['Workflow completed - Fraud Review Pending', '1'],
[],
['Fraud review rejected', '1'],
['Successfully Verified', '4'],
['Successfully Verified - With phone number', '1'],
['Successfully Verified - With mailed code', '1'],
Expand Down Expand Up @@ -162,6 +171,7 @@
'IdV Reject: Phone Finder' => 1,
'IdV Reject: Verify' => 1,
'Fraud: Profile review passed' => 2,
'Fraud: Profile review rejected' => 1,
)
end
end
Expand Down